Incorrect fpadd method referenced in Money.pm
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
| 2.11 |
Fix Released
|
Undecided
|
Unassigned | ||
| 2.12 |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Evergreen 2.9.1
OpenSRF 2.4.0
Debian Jessie 8.6
Postgres 9.3.15
I was curious why I was seeing log entries like
--
Can't locate object method "fpadd" via package "OpenILS:
--
from what I can gather, this is happening when staff are trying to adjust balances on certain negative balanced Lost Items to zero. Possibly caused by some combination of Lost/Void Library Settings?
For this library (Set to True):
-Void lost item billing when claims returned
-Void lost item processing fee when claims returned
-Void processing fee on lost item return
-Void overdue fines when items are marked lost
-Prohibit negative balance on bills (DEFAULT)
-Prohibit negative balance on bills lost materials
-Prohibit negative balance on bills for overdue materials
I'm assuming the correct method should be "fpsum", not "fpadd" as Open-ILS/
Am going to try changing fpadd to fpsum and seeing what happens...
++ thanks to Dan Wells for letting me bug him about it.
| Jeff Davis (jdavis-sitka) wrote | #1 |
| Jeff Davis (jdavis-sitka) wrote | #2 |
| Changed in evergreen: | |
| milestone: | none → 2.12.2 |
| milestone: | 2.12.2 → 3.0-alpha |
| status: | New → Confirmed |
| tags: | added: pullrequest |
| Changed in evergreen: | |
| assignee: | nobody → Dan Wells (dbw2) |
| Dan Wells (dbw2) wrote | #3 |
| no longer affects: | evergreen/3.0 |
| Changed in evergreen: | |
| status: | Confirmed → Fix Committed |
| assignee: | Dan Wells (dbw2) → nobody |
| Changed in evergreen: | |
| status: | Fix Committed → Fix Released |
We're seeing this error on 2.12. I'm testing a fix along the lines suggested by bmills.