widelands

Editor: packet 'Immovable' incompatibility in B19

Bug #1647033 reported by toptopple
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned
widelands build20-rc1

Bug Description

I saved my map "Gold Rush 1.1" with build 8199 (post-B19). When I try to open this map in B19 (Debug) I receive an incompatibility message and it does not open. There was already 1 player who reported this bug in the "Maps" download gallery as a comment on this map.

The message reports an incompatibility of packet "immovable.cc:706", UnhandledVersionError, saved version 8, current version 7.

SirVer mentions in the forum that this should not happen.

Related branches

lp://staging/~widelands-dev/widelands/bug-1647033-immovable-packet-no
toptopple (community): Approve
Diff: 50 lines (+15/-4)
1 file modified
src/logic/map_objects/immovable.cc (+15/-4)
Revision history for this message
GunChleoc (gunchleoc) wrote :

This is caused by the extra data that we need for former_building, so we can show a building name when a building is burning. This new data is only needed for game loading, not map loading.

We do need to load immovables into maps though, so not sure how to solve this one.

tags: added: editor savegame
Changed in widelands:
status: New → Confirmed
importance: Undecided → High
milestone: none → build20-rc1
Revision history for this message
TiborB (tiborb95) wrote :

I dont know the code, but would it be viable to use something like "Unknown" as a replacement of missing information?

Revision history for this message
GunChleoc (gunchleoc) wrote :

No - the problem is the packet format. There is no way that I can tell a past version of Widelands not to read something.

I have had an idea though - We could have 2 packet numbers, one for with former_building, and one for without. When saving, the Immovable can detect whether former_building == nullptr and if so, use the old packet version - this will give us the old packet version for map saving and loading.

GunChleoc (gunchleoc)
Changed in widelands:
assignee: nobody → GunChleoc (gunchleoc)
SirVer (sirver)
Changed in widelands:
status: Confirmed → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.