overcloud deploy uses the wrong path for non-relative templates

Bug #1646404 reported by Flavio Percoco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Flavio Percoco
Newton
Fix Released
High
Flavio Percoco

Bug Description

 If the template is not in the user's t-h-t root, we should use the absolute path instead of the one in the template since we've already copied these files in the temp dir.

This was introduced in I560784dc49842113563f617b343702bb045fca76

 ...
                        self.log.debug("Rewriting %s %s path to %s"
                                       % (env_path, rsrc, new_rsrc_path))
                        env_registry[rsrc] = new_rsrc_path
                    else:
                        env_registry[rsrc] = rsrc_path

Revision history for this message
Flavio Percoco (flaper87) wrote :
Changed in tripleo:
assignee: nobody → Flavio Percoco (flaper87)
tags: added: tripleoclient
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/405217

Steven Hardy (shardy)
Changed in tripleo:
importance: Undecided → High
milestone: none → ocata-2
status: New → In Progress
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/newton)

Reviewed: https://review.openstack.org/405217
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=cab30bc40031454fbeac1d47b12b94817e41567e
Submitter: Jenkins
Branch: stable/newton

commit cab30bc40031454fbeac1d47b12b94817e41567e
Author: Flavio Percoco <email address hidden>
Date: Wed Nov 30 14:06:56 2016 +0100

    Use the absolute path for temp templates

    If the template is not in the user's t-h-t root, we should use the
    absolute path instead of the one in the template since we've already
    copied these files in the temp dir.

    Closes-bug: #1646404

    Change-Id: I9a575575fc3c0fc78848239fc7b663ca4508fcfa

tags: added: in-stable-newton
Changed in tripleo:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 5.4.1

This issue was fixed in the openstack/python-tripleoclient 5.4.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.