Plan isn't purged of roles_data on a new create

Bug #1644875 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Invalid
High
Toure Dunnon

Bug Description

When you create a stack which references a custom roles_data.yaml, you want that to be sticky when doing an update of the stack, but not when you've deleted the stack and are creating a new stack from scratch, e.g consider the following:

openstack overcloud deploy --templates -r my_roles_data.yaml
heat stack-delete overcloud
<wait for the stack to be deleted)
openstack overcloud deploy --templates

This second deploy will use the my_roles_data.yaml, which isn't very intuitive - we should detect that this is a clean deploy and completely delete/create the plan I think.

The workaround is to manually delete the plan, but I think we can optimize the workflow above by differentiating between a deploy (create) and deploy (update) command.

Steven Hardy (shardy)
Changed in tripleo:
status: New → Triaged
milestone: none → ocata-2
importance: Undecided → Medium
tags: added: tripleoclient workflows
Revision history for this message
Steven Hardy (shardy) wrote :

Actually the reverse is also true - unlike all the -e options which are "sticky", if you forget to pass -r roles_data.yaml to any update, we ignore it as we purge everything from the --templates location and upload the default roles_data.yaml again.

So I think we'll need to rethink how/where this data is saved (move it to the mistral environment?)

Changed in tripleo:
milestone: ocata-2 → ocata-3
Dougal Matthews (d0ugal)
Changed in tripleo:
milestone: ocata-3 → pike-1
Steven Hardy (shardy)
Changed in tripleo:
importance: Medium → High
tags: added: ocata-backport-potential tripleo-common
removed: tripleoclient
tags: added: tripleoclient
Changed in tripleo:
milestone: pike-1 → ocata-rc1
Dougal Matthews (d0ugal)
Changed in tripleo:
assignee: nobody → Dougal Matthews (d0ugal)
Dougal Matthews (d0ugal)
Changed in tripleo:
assignee: Dougal Matthews (d0ugal) → nobody
Dougal Matthews (d0ugal)
Changed in tripleo:
assignee: nobody → Dougal Matthews (d0ugal)
Dougal Matthews (d0ugal)
Changed in tripleo:
assignee: Dougal Matthews (d0ugal) → nobody
Revision history for this message
Brad P. Crochet (brad-9) wrote :

The alternative command is to actually use 'openstack overcloud delete <stack>' command. This will delete both the stack and the plan.

Changed in tripleo:
milestone: ocata-rc1 → ocata-rc2
Changed in tripleo:
milestone: ocata-rc2 → pike-1
Changed in tripleo:
milestone: pike-1 → pike-2
Changed in tripleo:
milestone: pike-2 → pike-3
Changed in tripleo:
milestone: pike-3 → pike-rc1
Changed in tripleo:
milestone: pike-rc1 → pike-rc2
Changed in tripleo:
milestone: pike-rc2 → queens-1
Changed in tripleo:
milestone: queens-1 → queens-2
Changed in tripleo:
milestone: queens-2 → queens-3
Dougal Matthews (d0ugal)
tags: added: documentation
Changed in tripleo:
milestone: queens-3 → queens-rc1
Changed in tripleo:
milestone: queens-rc1 → rocky-1
Changed in tripleo:
milestone: rocky-1 → rocky-2
Toure Dunnon (toure)
Changed in tripleo:
assignee: nobody → Toure Dunnon (toure)
Toure Dunnon (toure)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Toure Dunnon (toure) wrote :

After looking into this issue the problem lies in the native heat clients inability to interface with swift to remove to once provided roles data. The OpenStack unified client places this data into the swift container and removes it upon deletion, to reference back what Brad stated. I would suggest not mixing the two clients in regards to a deployment workflow.

I will post an update to the clients release notes.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/570971

Changed in tripleo:
milestone: rocky-2 → rocky-3
Changed in tripleo:
milestone: rocky-3 → rocky-rc1
Revision history for this message
Toure Dunnon (toure) wrote :
Changed in tripleo:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.