A Mir client can crash the server by setting an invalid display configuration
Bug #1643446 reported by
Daniel van Vugt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Triaged
|
High
|
Unassigned | ||
| Mir |
Fix Released
|
High
|
Alan Griffiths | ||
| 0.26 |
Triaged
|
High
|
Unassigned | ||
Bug Description
Calling mir_output_enable() from a client can easily crash the server.
If that server happens to be mir_demo* then you will get a reason:
ERROR: ../src/
Dynamic exception type: boost::
std::exception:
Related branches
lp://staging/~alan-griffiths/mir/fix-1643446
- Brandon Schaefer (community): Approve
- Mir CI Bot: Approve (continuous-integration)
-
Diff: 60 lines (+17/-1)2 files modifiedsrc/server/scene/mediating_display_changer.cpp (+16/-0)
tests/unit-tests/scene/test_mediating_display_changer.cpp (+1/-1)
| description: | updated |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #1 |
| summary: |
- mir_output_enable() crashes the server + Calling mir_output_enable() from a client crashes the server |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote Re: Calling mir_output_enable() from a client crashes the server | #2 |
| summary: |
- Calling mir_output_enable() from a client crashes the server + Calling mir_output_enable() from a client can easily crash the server |
| description: | updated |
| summary: |
- Calling mir_output_enable() from a client can easily crash the server + A client can crash the server by setting an invalid display + configuration |
| tags: | added: multimonitor |
| Changed in mir: | |
| milestone: | none → 1.0.0 |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → High |
| milestone: | none → u8c-1 |
| tags: | added: unity8-desktop |
| summary: |
- A client can crash the server by setting an invalid display + A Mir client can crash the server by setting an invalid display configuration |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Stephen M. Webb (bregma) |
| Changed in canonical-devices-system-image: | |
| status: | New → Triaged |
| information type: | Public → Public Security |
| information type: | Public Security → Public |
| Changed in canonical-devices-system-image: | |
| milestone: | u8c-1 → u8c-2 |
| Changed in mir: | |
| milestone: | 0.27.0 → 0.28.0 |
Revision history for this message
| Alan Griffiths (alan-griffiths) wrote | #3 |
| Changed in canonical-devices-system-image: | |
| assignee: | Stephen M. Webb (bregma) → nobody |
| Changed in mir: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Alan Griffiths (alan-griffiths) |
| milestone: | none → 1.0.0 |
Revision history for this message
| Mir CI Bot (mir-ci-bot) wrote | #4 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I guess we don't bother to default all possibly "inconsistent" fields to something that's consistent.