Enable pep8 on the integration directory
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack DBaaS (Trove) |
In Progress
|
Low
|
Tin Lam | ||
Bug Description
Currently trove/integration is disabled for pep8. This should be fixed but it is a non-trivial effort.
What you have to do:
1. Wait till https:/
2. Update tox.ini and in the flake8 section, change the line that excludes 'integration'. See below.
[flake8]
show-source = True
# H301 is ignored on purpose.
# The rest of the ignores are TODOs.
ignore = F821,H301,
enable-extensions = H203,H106
builtins = _
exclude=
filename=
3. Once you delete 'integration', re-run tox -e pep8, you will be rewarded with a considerable number of errors. Fix ALL of them till you can get pep8 to pass.
4. Then verify that py27 and py34 also pass.
5. Then submit a change with your new tox.ini and all the changes you made
Good luck
| Changed in trove: | |
| assignee: | nobody → Tin Lam (tl3438) |
| OpenStack Infra (hudson-openstack) wrote Related fix merged to trove (master) | #1 |
| OpenStack Infra (hudson-openstack) wrote Fix proposed to trove (master) | #2 |
| Changed in trove: | |
| status: | New → In Progress |
| OpenStack Infra (hudson-openstack) wrote Change abandoned on trove (master) | #3 |
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 0a9b1e45fcf712d
Author: Amrith Kumar <email address hidden>
Date: Thu Nov 17 06:11:39 2016 -0500
Enable hacking extensions framework
<long rant deleted>
This change enables the hacking extensions ability in trove. That
includes bumping the version of hacking that we use, and also adding
the enable-extensions like in the [flake8] section. I've enabled two
of the hacking extensions here.
There are some limitations to the hacking rules that I've enabled so
I'm also going to enter two bugs that others can fix (if they so
desire).
Change-Id: I6d8fc4bc03f948
Related-Bug: 1642554
Related-Bug: 1642552