kolla

maxsize is not a valid logrotate option

Bug #1640196 reported by sean mooney on 2016-11-08

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
kolla	Invalid	Undecided	Unassigned	kolla ocata-1 "o1"
Liberty	Invalid	Undecided	Unassigned	kolla 1.1.3 "liberty"
Mitaka	Invalid	Undecided	Unassigned	kolla 2.0.3 "mitaka"
Newton	Invalid	Undecided	Unassigned	kolla 3.0.2 "newton"

Bug Description

currently kolla use maxsize to limit the size of log via logroate
https://github.com/openstack/kolla/blob/54cc601eedd1d299b345c7e4912798f7a5c2256c/ansible/roles/common/templates/cron-logrotate-global.conf.j2#L17

maxsize is not a valid logrotate option.

size should be used instead.

ref:https://linuxconfig.org/logrotate-8-manual-page

Revision history for this message

sean mooney (sean-k-mooney) wrote on 2016-11-08:

ps this effect stable/liberty on

Jeffrey Zhang (jeffrey4l) on 2016-11-11

Changed in kolla:
milestone:	none → ocata-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-11: Fix merged to kolla (master)

Reviewed: https://review.openstack.org/395024
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=c4107ed723354336427afb30bc3e25cd5303baf5
Submitter: Jenkins
Branch: master

commit c4107ed723354336427afb30bc3e25cd5303baf5
Author: Sean Mooney <email address hidden>
Date: Tue Nov 8 15:08:22 2016 +0000

corrects invalid logrotate option maxsize

    - logrotate does not have a maxsize option.
      while logrotate supports a minsize option its
      couterpart is size.
    - This chage replaces the use of maxsize with size
      in cron-logrotate-global.conf.j2

Change-Id: I381c52e8a866b74b5f2c3b38a2c87f74c48c05e1
Closes-Bug: #1640196

Changed in kolla:
status:	New → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-14: Change abandoned on kolla (stable/newton)

Change abandoned by Jeffrey Zhang (jeffrey.zhang@99cloud.net) on branch: stable/newton
Review: https://review.openstack.org/397012
Reason: wrong approach