python-senlinclient

filters in openstack cluster policy binding list

Bug #1634407 reported by miaohb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack SDK
Fix Released
Undecided
miaohb
python-senlinclient
Fix Released
Medium
miaohb
python-senlinclient ocata-2
senlin
Fix Released
High
miaohb
senlin ocata-2

Bug Description

In the help of openstack cluster policy binding list, the filters "type" and "name" are listed. However, they doesn't work actually:

stack@tecs:/home/python-senlinclient$ openstack cluster policy binding list -h
usage: openstack cluster policy binding list [-h]
                                             [-f {csv,json,table,value,yaml}]
                                             [-c COLUMN]
                                             [--max-width <integer>]
                                             [--noindent]
                                             [--quote {all,minimal,none,nonnumeric}]
                                             [--filters <key1=value1;key2=value2...>]
                                             [--sort <key>[:<direction>]]
                                             [--full-id]
                                             <cluster>

List policies from cluster.

positional arguments:
  <cluster> Name or ID of cluster to query on

optional arguments:
  -h, --help show this help message and exit
  --filters <key1=value1;key2=value2...>
                        Filter parameters to apply on returned results. This
                        can be specified multiple times, or once with
                        parameters separated by a semicolon. The valid filter
                        keys are: ['type', 'name']

miaohb (miao-hongbao)
Changed in python-senlinclient:
assignee: nobody → miaohb (miao-hongbao)
status: New → In Progress
miaohb (miao-hongbao)
Changed in python-openstacksdk:
assignee: nobody → miaohb (miao-hongbao)
status: New → In Progress
Changed in senlin:
assignee: nobody → miaohb (miao-hongbao)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/387870

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to senlin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/388505

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-senlinclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/388509

Qiming Teng (tengqim)
Changed in senlin:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to senlin (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/391012

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Related fix proposed to branch: master
Review: https://review.openstack.org/391034

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to senlin (master)

Reviewed: https://review.openstack.org/391012
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=e5409e3de3284869c7ccc32eebd51d1e9fe7a616
Submitter: Jenkins
Branch: master

commit e5409e3de3284869c7ccc32eebd51d1e9fe7a616
Author: miaohb <email address hidden>
Date: Thu Oct 27 11:09:22 2016 +0800

    Add "policy_type" and "policy_name" to CLUSTER_POLICY_ATTRS

    Add "policy_type" and "policy_name" to CLUSTER_POLICY_ATTRS,
    which will be used in policy binding list.

    Change-Id: If17d672b46d99950ab466e80c54b7e50f0b45e07
    Related-Bug: 1634407

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to senlin (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/391326

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to senlin (master)

Reviewed: https://review.openstack.org/391034
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=3c8a9357bd7f068c4225aef310ddc0e8413688a4
Submitter: Jenkins
Branch: master

commit 3c8a9357bd7f068c4225aef310ddc0e8413688a4
Author: miaohb <email address hidden>
Date: Thu Oct 27 13:02:26 2016 +0800

    Add cluster_policy_get_by_name to db api

    Add cluster_policy_get_by_name to db api, and its unit test is
    implemented also.
    Related-Bug: 1634407
    Depends-On: If17d672b46d99950ab466e80c54b7e50f0b45e07
    Change-Id: I18bcb239851cecd37818048a3d8fb126814bd4a9

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/391326
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=3f6e892b3a84e2702bf5563a4fe14e2a73d2fdae
Submitter: Jenkins
Branch: master

commit 3f6e892b3a84e2702bf5563a4fe14e2a73d2fdae
Author: miaohb <email address hidden>
Date: Fri Oct 28 11:22:50 2016 +0800

    Revise cluster_policy_get_by_type

    When filters include enabled and policy_type, exact_filter can not
    be used on ClusterPolicies directly, because policy_type is not
    the property of ClusterPolicies.

    Change-Id: Ief7dd8f59dddc7f17c7be875d86b662411fb4398
    Related-Bug: 1634407

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin (master)

Reviewed: https://review.openstack.org/388505
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=6e80bdbd5bb2247f2469b3e2632aba42177c84d2
Submitter: Jenkins
Branch: master

commit 6e80bdbd5bb2247f2469b3e2632aba42177c84d2
Author: miaohb <email address hidden>
Date: Wed Oct 19 15:47:57 2016 +0800

    Add filters "policy_name" and "policy_type" for policy binding list

    Revise cluster_policy_get_all, add policy_name and policy_type into
    filter whitelist of ClusterPolicyController, add related unit test

    Closed-Bug: 1634407
    Depends-On: I18bcb239851cecd37818048a3d8fb126814bd4a9,
                Ief7dd8f59dddc7f17c7be875d86b662411fb4398
    Change-Id: I452173dff86f75d82bfa967ea333ad42be95d488

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/387870
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=73f70f1a92a91753a5d8a26b1afed5900e5bb8ba
Submitter: Jenkins
Branch: master

commit 73f70f1a92a91753a5d8a26b1afed5900e5bb8ba
Author: miaohb <email address hidden>
Date: Tue Oct 18 17:10:02 2016 +0800

    Add filters "policy_type" and "policy_name" for policy binding list

    Add "policy_type" and "policy_name" to query map.
    Add QueryParameters related unit test case.

    Depends-On: I452173dff86f75d82bfa967ea333ad42be95d488
    Closed-Bug: 1634407
    Change-Id: I8363dadbb6afe810ceb161c59027eefca966f011

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-senlinclient (master)

Reviewed: https://review.openstack.org/388509
Committed: https://git.openstack.org/cgit/openstack/python-senlinclient/commit/?id=3fd8d24ef89267fcf0acb4468713b4a41c6959b5
Submitter: Jenkins
Branch: master

commit 3fd8d24ef89267fcf0acb4468713b4a41c6959b5
Author: miaohb <email address hidden>
Date: Wed Oct 19 15:54:21 2016 +0800

    Add filters "policy_type" and "policy_name" for policy binding list

    Modify the help message, from "type" to "policy_type", "name" to
    "policy_name"

    Depends-On: I8363dadbb6afe810ceb161c59027eefca966f011
    Closed-Bug: 1634407
    Change-Id: I738c309519fc0e04c946e0e09f619b08ec16af53

Revision history for this message
Yanyan Hu (yanyanhu) wrote :

Hi, hongbao, I marked this bug as fix committed since I noticed the patches in both senlin, senlinclient and sdk have been merged. Please reopen this bug if you feel it is still valid. Thanks a lot.

Changed in python-openstacksdk:
status: In Progress → Fix Committed
Changed in python-senlinclient:
status: In Progress → Fix Committed
Changed in senlin:
status: In Progress → Fix Committed
Revision history for this message
miaohb (miao-hongbao) wrote :

OK,thanks.

Qiming Teng (tengqim)
Changed in python-senlinclient:
importance: Undecided → Medium
milestone: none → ocata-2
Changed in senlin:
milestone: none → ocata-2
Qiming Teng (tengqim)
Changed in python-openstacksdk:
status: Fix Committed → Fix Released
Changed in python-senlinclient:
status: Fix Committed → Fix Released
Changed in senlin:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.