Mudlet crashes when creating new profile
Bug #1633786 reported by
Chris Leacy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mudlet |
Fix Released
|
Critical
|
Stephen Lyons | ||
Bug Description
3.0-epsilon
When creating a new profile, after entering the profile name / or pressing tab to move to the next field, mudlet crashes.
| Changed in mudlet: | |
| status: | New → Confirmed |
| importance: | Undecided → Critical |
| assignee: | nobody → Stephen Lyons (slysven) |
Revision history for this message
| Stephen Lyons (slysven) wrote | #1 |
Revision history for this message
| Stephen Lyons (slysven) wrote | #2 |
| Changed in mudlet: | |
| status: | Confirmed → In Progress |
| Changed in mudlet: | |
| status: | In Progress → Fix Committed |
| Changed in mudlet: | |
| milestone: | none → 3.0.0 |
| Changed in mudlet: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Aaargh, for a new profile when the name is attempted to be looked up in the (QStringList)
I had previous spotted that the number returned by indexOf(...) could be 0 and ensured that where the number was used as a divisor to generate the sixth of six pseudo-random 0-255 value use to give non-predefined MUD profile icons a random colour shaded icon then 1 (one) was added to it to make sure there could not be a crash caused if the new profile name happened to match the first profile "Avalon". In doing that I have now greatly increased the likely-hood of a crash as the zero divisor will be so for ANY new profile name that is not (correctly as it happens) in the existing list.
Fix in progress right now.