economy settings only reachable through flag menu

I am pretty sure we had this discussion on the bug tracker before, but I cannot find it right now :/.

The problem is that these settings are per economy: if you have two disjunct settlements (not even connected through ships) like you can have in scenario games or when you play with multiple headquarter start locations. The question is: where should the menu be triggered from then? It can't be a global menu, since the options are not global. And there is no per-economy setting besides this.

That's right of course!
Two little suggestions:

- Let the tooltip reflect this, e.g. "configure this economy"
- Have the option when clicking on any position in an economy, not only on flags

The only positions in an economy are flags owned by the player, buildings and ships. We could add a button to building windows?

Clicking on a flag that's not owned isn't feasible - you could have a headquarters and a warehouse and then cut all the roads between them. So, a flag not owned by a player would have no way to tell which economy to pick.

How about the warehouses/ports/HQs? They are logically connected to setting target quantities, and economies without one can't really be configured. Potential downside is the potential confusion between the wares stored in that particular warehouse and those in an entire economy combined.

On the other hand, I would welcome an easy way to provide a cache of goods in the warehouses where they are needed, for instance building materials on the expanding edge(s) of a large empire. Probably a different bug though. :)

couldn't it be possible to click every position inside the current economy...every building, every flag, every point on a road but without a flag, and every point not on a road...
just to assume that an economy is convex and every point inside it leads to the current settings

You can't assume that an economy is convex. Assume that you have a map like with 2 land masses like this:

    #############################
  ###########################
#### ############
#### ##### ooooooooooo
#### ooooooooo ##### ooooooo
## oooooo ###### oooooooooooo
### ooo ooooooooooooo
#### oooooooooooooooooooooooooooooooooooo
###
################
###################

I think having it in the warehouse would be too confusing, but we could have a button in each warehouse window that will open the economy window. And while we're at it, why not have the button in each building window.

In the beginning i was very confused about this options and until now i use this window very rarely. It is not good explained what these settings do.

> why not have the button in each building window

I think it should only be in related buildings window. E.g. having this in military buildings (except trainingsites) is not logical.

The configure economy window should only reflect economy options for this building then. E.g. clciking on "economy options" in stonemasons house could only show economy options for "Columns", bakery -> bread, toolsmith -> All the tools, smelting works -> gold and iron, Coalmine -> coal, Marmor mine stone and marmor, and so on. Clicking on a flag could then show all options, as a shortcut.

This may could help understanding these options. Having less icons means more space for additional help texts.

+1 for #7 :)

Nice idea :)
When clicking on a warehouse, port, or headquarter perhaps the economy settings could even be merged with the existing tabs so that no new window has to be opened

Migrated to https://github.com/widelands/widelands/issues/2063