MAAS

[FUJ] SSH input field not indicated for invalid username & the error is incomprehensible

Bug #1628114 reported by Maria Vrachni
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Newell Jensen
MAAS 2.1.0

Bug Description

MAAS bzr5400
Error message for deleted Launchapad ID is unclear

Bug description:

* Current result:

Given I am in the SSH section of the first use journey
When I add a Launchpad ID that has been deleted from Launchpad (Try input ggg for ID)
Then  I get the message shown in the screenshot

* Expected/ correct result:

Given I am in the SSH section of the first use journey
When I add a Launchpad ID that has been deleted from Launchpad (e.g. ggg)
Then I should get a clear message explaining the error

[OS X Sierra]

[Chrome, 53.0.2785.116 (64-bit)]

See original description

Related branches

lp://staging/~newell-jensen/maas/fix-1628114
Gavin Panella (community): Approve
Diff: 55 lines (+12/-6)
2 files modified
src/maasserver/utils/keys.py (+6/-2)
src/maasserver/utils/tests/test_keys.py (+6/-4)
Revision history for this message
Maria Vrachni (m-vrachnis) wrote :
Maria Vrachni (m-vrachnis)
description: updated
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hi Maria,

I believe this has already been fixed. Please try to latest MAAS and retry. If you confirm it hasn'tn been fixed, please mark this bug from "Fix ReleaseD" to "New".

Thanks!

Changed in maas:
status: New → Fix Released
milestone: none → 2.1.0
Brendan Donegan (brendan-donegan)
summary: [FUJ] SSH input field not indicated for invalid username & the error is
- incomprehensive
+ incomprehensible
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

It's not fixed - this is in trunk

Changed in maas:
status: Fix Released → Triaged
importance: Undecided → High
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

We should handle 401 and 404 errors with something like:

"It appears that Launchpad user '{{user}}' does not exist."

Newell Jensen (newell-jensen)
Changed in maas:
assignee: nobody → Newell Jensen (newell-jensen)
Revision history for this message
Newell Jensen (newell-jensen) wrote :

This is actually a 410 error but should be handled in a similar way.

Changed in maas:
status: Triaged → In Progress
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Typo on my part - 410 is gone, not 401

MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Maria, or anyone else affected,

Accepted maas into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/maas/2.1.0+bzr5480-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Andres Rodriguez (andreserl) wrote :

I've tested this and can confirm it has been fixed. Marking verification-done

tags: added: verification-done
removed: verification-needed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of the Stable Release Update for maas has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.