senlin

cluster policy attach

Bug #1626833 reported by miaohb
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-senlinclient
Fix Released
Undecided
miaohb
senlin
Fix Released
Medium
miaohb
senlin newton-rc2

Bug Description

The parameter "--enabled" in cluster-policy-attach is useless，which cannot be set to False.

miaohb (miao-hongbao)
Changed in senlin:
assignee: nobody → miaohb (miao-hongbao)
status: New → In Progress
Changed in python-senlinclient:
assignee: nobody → miaohb (miao-hongbao)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to senlin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/375245

Revision history for this message
Qiming Teng (tengqim) wrote :

it is a boolean flag from command line, so a simple fix would be change senlinclient so that the command becomes:

  senlin cluster-policy-attached --disabled

if --disabled is not specified, which is the default, then we enable the policy.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-senlinclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/375254

Revision history for this message
miaohb (miao-hongbao) wrote :

To add a new parameter "--disabled" can also fix this problem. But the new parameter will impact engine/api's code likewise.

Revision history for this message
Qiming Teng (tengqim) wrote :

okay, agreed on fixing the --enabled parameter rather than introduce a --disabled parameter.

Qiming Teng (tengqim)
Changed in senlin:
importance: Undecided → Medium
milestone: none → newton-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin (master)

Reviewed: https://review.openstack.org/375245
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=44251d9985a4c0da7c0ed6f20a7ae6e9523ba7d1
Submitter: Jenkins
Branch: master

commit 44251d9985a4c0da7c0ed6f20a7ae6e9523ba7d1
Author: miaohb <email address hidden>
Date: Fri Sep 23 13:12:12 2016 +0800

    revise the "cluster-policy-attach"

    The parameter "--enabled" in "cluster policy attach" is useless,
    which can not be set to False. Here we try to fix it so that
    the parameter can be assigned to False when doing attach.

    Change-Id: I0b5de3c6f61c38c62ac8c7e1b95d523175bbc11c
    Closed-Bug: 1626833

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-senlinclient (master)

Reviewed: https://review.openstack.org/375254
Committed: https://git.openstack.org/cgit/openstack/python-senlinclient/commit/?id=6612e928f1ccffe8ea588281771ef4b5b383d5ed
Submitter: Jenkins
Branch: master

commit 6612e928f1ccffe8ea588281771ef4b5b383d5ed
Author: miaohb <email address hidden>
Date: Fri Sep 23 13:40:35 2016 +0800

    revise the "cluster-policy-attach"

    The parameter "--enabled" in "cluster policy attach" is useless,
    which can not be set to False. Here we try to fix it so that
    the parameter can be assigned to False when doing attach.

    Change-Id: I0b5de3c6f61c38c62ac8c7e1b95d523175bbc11c
    Closed-Bug: 1626833

Qiming Teng (tengqim)
Changed in senlin:
status: In Progress → Fix Released
Changed in python-senlinclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.