Juju Charms Collection
ceph-mon package

multiple upgrades of same units results in concurrent, not rolling upgrade

Bug #1611719 reported by James Page
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ceph (Juju Charms Collection)
Fix Released
High
Unassigned
Juju Charms Collection 16.10
ceph-mon (Juju Charms Collection)
Fix Released
High
Unassigned
Juju Charms Collection 16.10
ceph-osd (Juju Charms Collection)
Fix Released
High
Unassigned
Juju Charms Collection 16.10

Bug Description

I noticed this testing upgrades in the follow order:

cloud:trusty-kilo (base deployment)
cloud:trusty-liberty (first upgrade - rolling and OK)
cloud:trusty-mitaka (second upgrade - concurrent and OK).

The code in the charms calls:

def wait_on_previous_node(previous_node):
    log("Previous node is: {}".format(previous_node))

    previous_node_finished = monitor_key_exists(
        'admin',
        "{}_done".format(previous_node))

- the _done key exists from the upgrade to trusty-liberty, so the wait gets skipped altogether resulting in a concurrent upgrade, rather than a rolling upgrade.

James Page (james-page)
Changed in ceph (Juju Charms Collection):
importance: Undecided → Critical
Changed in ceph-mon (Juju Charms Collection):
importance: Undecided → Critical
Changed in ceph-osd (Juju Charms Collection):
importance: Undecided → Critical
tags: added: stable-candidate
James Page (james-page)
Changed in ceph (Juju Charms Collection):
importance: Critical → High
Changed in ceph-mon (Juju Charms Collection):
importance: Critical → High
Changed in ceph-osd (Juju Charms Collection):
importance: Critical → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-mon (master)

Reviewed: https://review.openstack.org/353667
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-mon/commit/?id=8cb9b32c40599c20157ed900b705bb9ad7eef44c
Submitter: Jenkins
Branch: master

commit 8cb9b32c40599c20157ed900b705bb9ad7eef44c
Author: Chris Holcombe <email address hidden>
Date: Wed Aug 10 10:58:21 2016 -0700

    Allow multiple rolling upgrades

    The rolling upgrade code sets keys in the ceph monitor
    cluster to discover whether it can upgrade itself. This
    patch addresses an issue where the upgrade code was not
    taking into account multiple upgrades to newer ceph versions
    in a row.

    Closes-Bug: 1611719
    Change-Id: Icc7c2f48517b9b4bc7d6526e2c89756341296054

Changed in ceph-mon (Juju Charms Collection):
status: New → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to charm-ceph-osd (master)

Reviewed: https://review.openstack.org/364400
Committed: https://git.openstack.org/cgit/openstack/charm-ceph-osd/commit/?id=87672f47961a4efb59ade1e31656f028ff05bf25
Submitter: Jenkins
Branch: master

commit 87672f47961a4efb59ade1e31656f028ff05bf25
Author: Chris Holcombe <email address hidden>
Date: Thu Sep 1 08:34:21 2016 -0700

    Allow multiple rolling upgrades

    The rolling upgrade code sets keys in the ceph osd
    cluster to discover whether it can upgrade itself. This
    patch addresses an issue where the upgrade code was not
    taking into account multiple upgrades to newer ceph versions
    in a row.

    Closes-Bug: 1611719
    Change-Id: I467d95f3619b9ad2a9f4f46abee4e02b5d9703da

Changed in ceph-osd (Juju Charms Collection):
status: New → Fix Committed
James Page (james-page)
Changed in ceph-mon (Juju Charms Collection):
status: Fix Committed → Fix Released
Changed in ceph-osd (Juju Charms Collection):
status: Fix Committed → Fix Released
Changed in ceph-mon (Juju Charms Collection):
milestone: none → 16.10
Changed in ceph-osd (Juju Charms Collection):
milestone: none → 16.10
Changed in ceph (Juju Charms Collection):
status: New → Fix Released
milestone: none → 16.10
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.