Validation errors should be fatal by default

Bug #1608624 reported by Ben Nemec
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Ben Nemec

Bug Description

Currently both warnings and errors are non-fatal by default in tripleoclient. This makes very little sense since errors should be things that are pretty much guaranteed to fail the deployment. The only time an error should be ignored is if there is a bug in the validation. If a deployment can happen in spite of the problem, then that should be a warning.

For an example of where this can bite deployers, see https://bugzilla.redhat.com/show_bug.cgi?id=1360421 Because the validation error does not immediately stop the deployment, we attempt to update an invalid environment and hose the deployment.

To my knowledge, the current best practice in the field is to set validation errors to fatal anyway, so this is just aligning our defaults with the real world use case.

Ben Nemec (bnemec)
Changed in tripleo:
assignee: nobody → Ben Nemec (bnemec)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/349609

Changed in tripleo:
status: Triaged → In Progress
Steven Hardy (shardy)
Changed in tripleo:
milestone: none → newton-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/349609
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=bb9a7e244e00f18c936ca5736e6a4de9783a4ef8
Submitter: Jenkins
Branch: master

commit bb9a7e244e00f18c936ca5736e6a4de9783a4ef8
Author: Ben Nemec <email address hidden>
Date: Mon Aug 1 17:38:43 2016 +0000

    Make validation errors fatal by default

    The current situation where errors and warnings are treated the same
    does not make sense. Errors should be things where the deployment
    cannot continue. If it's possible to deploy anyway, then that
    should be a warning.

    It could be argued that this should be notified for a cycle before
    actually changing, but the current default is actually causing
    deployers grief already because everyone has to remember to pass
    --validation-errors-fatal to get sane behavior. As noted in the
    bug, the non-fatal default can have very bad consequences for users
    who don't follow that best practice. Essentially this is a CLI
    bug that causes confusion and worse for users and a deprecation
    cycle will only prolong that pain. The only pain making the change
    now should cause is possibly finding bugs in the validations, which
    should be fixed anyway.

    Change-Id: I9f77cd66547082b390c0c15034a2759e431045c5
    Closes-Bug: 1608624

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 5.0.0

This issue was fixed in the openstack/python-tripleoclient 5.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.