Percona Server moved to https://jira.percona.com/projects/PS

gitignore lists *.spec

Bug #1600051 reported by Chris Giard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Status tracked in 5.7
5.5
Fix Released
Medium
EvgeniyPatlan
Percona Server moved to https://jira.percona.com/projects/PS 5.5.51-38.1
5.6
Fix Released
Medium
EvgeniyPatlan
Percona Server moved to https://jira.percona.com/projects/PS 5.6.32-78.0
5.7
Fix Released
Medium
EvgeniyPatlan
Percona Server moved to https://jira.percona.com/projects/PS 5.7.14-7

Bug Description

The included .gitignore in the percona-server 5.7 build has a line "*.spec", which means someone trying to checkin a copy of the percona-server source will be missing the spec file required to build the RPMs. That line should be removed from the file.

Revision history for this message
EvgeniyPatlan (evgeniy-patlan) wrote :

Hi Chris.

It means that it wouldn't be possible to put *.spec file into root dir. But as you might know the *.spec is placed into `build-ps` dir so there shouldn't be any issues.

Revision history for this message
Chris Giard (cmg-l) wrote :

Because it doesn't have a path specifier in it, "*.spec" applies to files in all directories in the repo, not just the root. To restrict it to the root you need to put "/*.spec"

Laurynas Biveinis (laurynas-biveinis)
tags: added: upstream
Revision history for this message
EvgeniyPatlan (evgeniy-patlan) wrote :

https://github.com/percona/percona-server/pull/651
https://github.com/percona/percona-server/pull/652
https://github.com/percona/percona-server/pull/653

Revision history for this message
Tomislav Plavcic (tplavcic) wrote :

The upstream is using ".spec.in" files in their packaging directory which are spec templates from which they generate ".spec" files with cmake. So I don't think it is an upstream issue. Since we are not using those templates currently we can remove it, but if we start using it at some point we should re-add this.

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

This looks like an upstream bug and should be reported there too.

Tomislav Plavcic (tplavcic)
tags: removed: upstream
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

I see, thank you

EvgeniyPatlan (evgeniy-patlan)
Changed in percona-server:
status: New → Fix Committed
milestone: none → 5.7.14-7
milestone: 5.7.14-7 → 5.6.32-77.1
milestone: 5.6.32-77.1 → 5.7.14-7
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1726

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.