[webapp-container] Overlay created as Popups should not have an "open in the webrowser" button
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webapps-sprint |
In Progress
|
Medium
|
Alexandre Abreu | ||
| webbrowser-app (Ubuntu) |
In Progress
|
Medium
|
Alexandre Abreu | ||
Bug Description
In the webapp container, overlays can be created through a href with target="_blank" or or window.open, the latter usually being used to open a popup window. Those should be treated differently than the usual overlay since they should be considered as part of the website flow and might communicate with the original website through e.g. window.postMessage.
For those overlays, it does not make much sense to have a "open in webbrowser" button at the top right.
An example of those popups & windows can be found in here maps.
1. go to https:/
2. click 'signin'
3. a new overlay is created with the Oxide.Navigatio
4. if you click 'login with facebook' a new overlay is created but it is created with Oxide.Navigatio
Related branches
- Alberto Mardegan (community): Approve
- system-apps-ci-bot: Needs Fixing (continuous-integration)
-
Diff: 81 lines (+26/-3)3 files modifiedsrc/app/webcontainer/PopupWindowController.qml (+9/-2)
src/app/webcontainer/PopupWindowOverlay.qml (+2/-1)
tests/autopilot/webapp_container/tests/test_popup_webview_overlay.py (+15/-0)
| Changed in webbrowser-app (Ubuntu): | |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| Changed in webapps-sprint: | |
| milestone: | none → sprint-24 |
| assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
| Changed in webapps-sprint: | |
| importance: | Undecided → Medium |
| Changed in webbrowser-app (Ubuntu): | |
| importance: | Undecided → Medium |
| summary: |
- Overlay created as Popups should not have an "open in the webrowser" - button + [webapp-container] Overlay created as Popups should not have an "open in + the webrowser" button |
| Changed in webapps-sprint: | |
| status: | New → Confirmed |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Confirmed |
| Changed in webapps-sprint: | |
| milestone: | sprint-24 → sprint-25 |
| Changed in webapps-sprint: | |
| status: | Confirmed → In Progress |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Confirmed → In Progress |
| Alberto Mardegan (mardy) wrote | #1 |
I've removed the fix for this issue from silo 67, as I cannot test the bug according the steps provided in the bug description: when I click on "login with facebook", the page simply reloads and nothing happens.