OpenStack Backup/Restore and DR (Freezer)

Freezer Agent does not trap tar restore errors

Bug #1595670 reported by Deklan Dieterly
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Backup/Restore and DR (Freezer)
Fix Released
Undecided
Deklan Dieterly
OpenStack Backup/Restore and DR (Freezer) newton-2 "n2"
Mitaka
Fix Committed
Undecided
Unassigned

Bug Description

When doing a restore, if an error occurs with tar, the tar error is not logged. Only

 Engine error: [Errno 32] Broken pipe

is logged. The root cause of the error is not captured and logged. This is because the exception is bypassing the process error checks.

For example.

2016-06-16 15:18:44.364 10868 INFO freezer.job [-] [*] Executing FS restore...
2016-06-16 15:18:44.378 10868 INFO freezer.engine.engine [-] Creation restore path: /tmp/freezer-test-backup-restore/ecc3b2d899164edcb0d2f126769bda16
2016-06-16 15:18:44.378 10868 INFO freezer.engine.engine [-] Creation restore path completed
2016-06-16 15:18:44.378 10868 INFO freezer.engine.engine [-] Restore backup deklans-macbook-pro_freezer-test-backup-swift-0_1466111923_0
2016-06-16 15:18:44.426 10868 CRITICAL freezer.engine.engine [-] Engine error: [Errno 32] Broken pipe
2016-06-16 15:18:44.427 10868 CRITICAL freezer.main [-] [*] Critical Error: Engine error. Failed to restore file.

Deklan Dieterly (deklan)
Changed in freezer:
status: New → In Progress
assignee: nobody → Deklan Dieterly (deklan)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to freezer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/333543

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to freezer (master)

Reviewed: https://review.openstack.org/333543
Committed: https://git.openstack.org/cgit/openstack/freezer/commit/?id=b3bc12b02cadb9531202ac661b33ec1d0c71ee4b
Submitter: Jenkins
Branch: master

commit b3bc12b02cadb9531202ac661b33ec1d0c71ee4b
Author: Deklan Dieterly <email address hidden>
Date: Thu Jun 23 13:12:29 2016 -0600

    Fix restore tar error handling

    Capture errors from tar during restore and log them.
    Propogate restore tar errors up thru the exception mechanism.
    Refactor process check to remove duplicate code.
    Propagate exceptions from tar for both backup and restore
    up to main instead of exiting the process.

    Change-Id: I43de55e271a34d7b497760905f168d2d7a3ab28c
    Closes-Bug: #1595670

Changed in freezer:
status: In Progress → Fix Released
Pierre-Arthur MATHIEU (pi3rra)
Changed in freezer:
milestone: none → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to freezer (stable/mitaka)

Reviewed: https://review.openstack.org/337604
Committed: https://git.openstack.org/cgit/openstack/freezer/commit/?id=e36b0c1c1adaabf7641f4c80358a7721ee7cb944
Submitter: Jenkins
Branch: stable/mitaka

commit e36b0c1c1adaabf7641f4c80358a7721ee7cb944
Author: Deklan Dieterly <email address hidden>
Date: Thu Jun 23 13:12:29 2016 -0600

    Fix restore tar error handling

    Capture errors from tar during restore and log them.
    Propogate restore tar errors up thru the exception mechanism.
    Refactor process check to remove duplicate code.
    Propagate exceptions from tar for both backup and restore
    up to main instead of exiting the process.

    Closes-Bug: #1595670
    (cherry picked from commit b3bc12b02cadb9531202ac661b33ec1d0c71ee4b)
    Change-Id: I43de55e271a34d7b497760905f168d2d7a3ab28c

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/freezer 3.0.0.0b2

This issue was fixed in the openstack/freezer 3.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.