Ctrl+f should focus the find text box when it is visible
Bug #1592699 reported by
Zisu Andrei
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Scratch |
Fix Released
|
Medium
|
Jeremy Wootten | ||
Bug Description
In most editors (atom, intellij, sublime), when you press ctrl+f:
If the find toolbar is not shown, it will be shown
If the find toolbar is shown but not focused, if will be focued
The find toolbar is hidden by pressing esc (just like Scratch does).
Related branches
lp://staging/~jeremywootten/scratch/fix-1592699-focus-search-box
- Zisu Andrei (community): Approve
-
Diff: 154 lines (+52/-32)3 files modifiedsrc/MainWindow.vala (+48/-29)
src/Widgets/ToolBar.vala (+1/-1)
src/scratch-ui.xml (+3/-2)
Revision history for this message
| Zisu Andrei (matzipan) wrote | #1 |
Revision history for this message
| Jeremy Wootten (jeremywootten) wrote | #2 |
Revision history for this message
| Zisu Andrei (matzipan) wrote | #3 |
Revision history for this message
| Zisu Andrei (matzipan) wrote | #4 |
| summary: |
- Ctrl+f should focus the find text box + Ctrl+f should focus the find text box when it is visible |
| Changed in scratch: | |
| status: | New → Confirmed |
| importance: | Undecided → Medium |
| Changed in scratch: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Jeremy Wootten (jeremywootten) |
| Changed in scratch: | |
| status: | In Progress → Fix Committed |
| Changed in scratch: | |
| milestone: | none → loki-rc1 |
| Changed in scratch: | |
| milestone: | loki-rc1 → loki-alpha1 |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Further, if a bit of text is selected when pressing ctrl+f, then this should be the value of the search query.