kolla

ml2_conf.ini has inconsistent template configuration

Bug #1592444 reported by Derek Ditch
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
High
Derek Ditch
kolla newton-2 "n2"
Liberty
Fix Released
High
Derek Ditch
kolla 1.1.2 "liberty"
Mitaka
Fix Released
High
Derek Ditch
kolla 2.0.2 "mitaka"

Bug Description

I was trying to customize ml2_conf.ini on a single host in my cloud so that I could add an additional physnet bridge mapping when I noticed an inconsistency in the configuration. My changes weren't being pushed to the nodes. As it turns out, the current task uses the `merge_configs` module to pull in values from the `ml2_conf.ini.j2` template, the global neutron ml2_conf.ini config, then the inventory hostname specific version, except it pulls in values from `neutron.conf`, not `ml2_conf.ini` as expected.

This bug goes back to at least the stable/liberty branch. I request that this is backported to at least stable/mitaka for production use.

```
- name: Copying over ml2_conf.ini
  merge_configs:
    vars:
      service_name: "{{ item }}"
    sources:
      - "{{ role_path }}/templates/ml2_conf.ini.j2"
      - "{{ node_custom_config }}/neutron/ml2_conf.ini"
      - "{{ node_custom_config }}/neutron/{{ inventory_hostname }}/neutron.conf"
    dest: "{{ node_config_directory }}/{{ item }}/ml2_conf.ini"
  with_items:
    - "neutron-dhcp-agent"
    - "neutron-l3-agent"
    - "neutron-linuxbridge-agent"
    - "neutron-metadata-agent"
    - "neutron-openvswitch-agent"
    - "neutron-server"
```

Excerpt taken from https://github.com/openstack/kolla/blob/ba30579b3b3e69536f5bd59e57d39ed4b63a2dd6/ansible/roles/neutron/tasks/config.yml#L72

Swapnil Kulkarni (coolsvap-deactivatedaccount)
Changed in kolla:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Derek Ditch (dcode)
milestone: none → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/329506
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=977a46ce225249f9596e556dbc48bd50226d8983
Submitter: Jenkins
Branch: master

commit 977a46ce225249f9596e556dbc48bd50226d8983
Author: Derek Ditch <email address hidden>
Date: Tue Jun 14 10:02:12 2016 -0500

    Makes ml2_conf.ini configuration consistent

    Change-Id: I10f2209428b21cd3dedb6b7fb14e9de34bbf3fa4
    Closes-Bug: 1592444

Changed in kolla:
status: Confirmed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/mitaka)

Reviewed: https://review.openstack.org/329758
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=ad950e131d81bd85f91c7731f6ef376900d26684
Submitter: Jenkins
Branch: stable/mitaka

commit ad950e131d81bd85f91c7731f6ef376900d26684
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Wed Jun 15 10:12:39 2016 +0530

    Makes ml2_conf.ini configuration consistent

    Closes-Bug: 1592444
    (cherry picked from commit 977a46ce225249f9596e556dbc48bd50226d8983)

    Change-Id: I2f14b178bd00052f90b35b519a54d59e388f24f3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/liberty)

Reviewed: https://review.openstack.org/329760
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=6e7dc0b0f91ea770b62140b72598325235d884be
Submitter: Jenkins
Branch: stable/liberty

commit 6e7dc0b0f91ea770b62140b72598325235d884be
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Wed Jun 15 10:14:28 2016 +0530

    Makes ml2_conf.ini configuration consistent

    Closes-Bug: 1592444
    (cherry picked from commit 977a46ce225249f9596e556dbc48bd50226d8983)

    Change-Id: I8101e80577bfe3f6209aa744e0f6b3194eddf3e2

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 3.0.0.0b2

This issue was fixed in the openstack/kolla 3.0.0.0b2 development milestone.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 2.0.2

This issue was fixed in the openstack/kolla 2.0.2 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/kolla 1.1.2

This issue was fixed in the openstack/kolla 1.1.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

This issue was fixed in the openstack/kolla 1.1.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.