handling of webroot: "" could be improved.

Can you retry with webroot: /

I think using an empty string will break things.

That was it for that one .. thanks..

On Wed, Jun 8, 2016 at 11:24 AM, James Page <email address hidden> wrote:
> Can you retry with webroot: /
>
> I think using an empty string will break things.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1590309
>
> Title:
> Services not running that should be: apache2
>
> Status in openstack-dashboard package in Juju Charms Collection:
> New
>
> Bug description:
>
> Version 240, msg on juju status:
> Services not running that should be: apache2
>
> Context:
> Maas 1.9.3+bzr4577-0ubuntu1
> juju 2.0-beta8-0ubuntu1~14.
>
>
> Deeper investigation :
> Command on openstack-dashboard/0:
>
> ubuntu@juju-574aab-3-lxc-1:~$ sudo service apache2 restart
> * Restarting web server apache2
> ...fail!
> * The apache2 configtest failed.
> Output of config test was:
> AH00526: Syntax error on line 1 of /etc/apache2/conf-enabled/openstack-dashboard.conf:
> WSGIScriptAlias requires at least two arguments, Map location to target WSGI script file.
> Action 'configtest' failed.
> The Apache error log may have more information.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/charms/+source/openstack-dashboard/+bug/1590309/+subscriptions

--
Best Regards,
       Nicolas Thomas
http://insights.ubuntu.com/?p=889
EMEA Solution Architect Canonical
GPG FPR: D592 4185 F099 9031 6590 6292 492F C740 F03A 7EB9

Nicholas

The charm should probably handle this a little better (for example converting a null or empty value to /) - this should be a fairly trivial change - fancy taking a shot at it?

Reviewed: https://review.openstack.org/431625
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=9ad940a425c6150aec316b26f5ad4311d8b7b9c5
Submitter: Jenkins
Branch: master

commit 9ad940a425c6150aec316b26f5ad4311d8b7b9c5
Author: Liam Young <email address hidden>
Date: Thu Feb 9 16:00:43 2017 +0000

    Add default for webroot

    If the webroot is set to an empty string then the rendered
    Apache config is syntactically invalid so this change
    sets it to '/' as a sensible default

    Change-Id: Iae1ca509e9668a676a1220f354e3f9a5f0e2aadf
    Closes-Bug: 1590309