Model name validation error doesn't specify model name

Bug #1590095 reported by Nicholas Skaggs
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
Mick Gregg

Bug Description

As seen in http://reports.vapour.ws/releases/issue/5757063f749a561bd992d765.

Our CI tests used to contain underscores which caused this error to appear. However, despite the fact our model name is akin to maas-1_9-deploy-trusty-amd64, the error message displayed is:

"name" is not a valid name: model names may only contain lowercase letters, digits and hyphens

Obviously "name" is perfectly valid according to what's listed in the message, so this should display the actual name that is an issue.

-----------
if !names.IsValidModelName(cfg.mustString(NameKey)) {
  return fmt.Errorf("%q is not a valid name: model names may only contain lowercase letters, digits and hyphens", NameKey)
 }

Changed in juju-core:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Mick Gregg (macgreagoir)
milestone: none → 2.0-beta9
Revision history for this message
Mick Gregg (macgreagoir) wrote :
Changed in juju-core:
status: Triaged → In Progress
Mick Gregg (macgreagoir)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
affects: juju-core → juju
Changed in juju:
milestone: 2.0-beta9 → none
milestone: none → 2.0-beta9
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.