Murano

[dashboard] _data_table.html checks string representation of packages to check empty list

Bug #1584802 reported by Kirill Zaitsev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Low
Kirill Zaitsev
Murano newton-2 "n2"

Bug Description

_data_table.html checks string representation of packages to check empty list like this:
{% if apps != '[]' %}

meaning it would be impossible to actually iterate over apps, since they're converted to string before they're passed to template.

Tags: dashboard
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/319963

Changed in murano:
assignee: nobody → Kirill Zaitsev (kzaitsev)
status: Confirmed → In Progress
Kirill Zaitsev (kzaitsev)
Changed in murano:
milestone: newton-1 → newton-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/319963
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=b7a6a23344d3c7fecf2d3f15d2e6d48ec92a0950
Submitter: Jenkins
Branch: master

commit b7a6a23344d3c7fecf2d3f15d2e6d48ec92a0950
Author: Kirill Zaitsev <email address hidden>
Date: Mon May 23 17:27:41 2016 +0300

    Use template filter to convert list of packages in the template

    Before this patch _data_table.html checked string
    representation to check if the list is empty.

    This patch adds jsonify filter and moves actual jsonification into
    template, thus eliminating the need to compare string representation of
    lists.

    Change-Id: Iddf6ab7c8cff1d1dff98badbd117200e9d3b22e7
    Closes-Bug: #1584802

Changed in murano:
status: In Progress → Fix Released
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/murano-dashboard 3.0.0.0b2

This issue was fixed in the openstack/murano-dashboard 3.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.