OpenStack Dashboard (Horizon)

Angular registry - Cannot read property 'itemActions' of undefined

Bug #1579262 reported by Travis Tripp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Matt Borland
OpenStack Searchlight
Fix Released
High
Travis Tripp
OpenStack Searchlight newton-1 "n1"

Bug Description

If you attempt to use initActions for a resource type that hasn't been registered, and error is thrown:

angular.js:11707 TypeError: Cannot read property 'itemActions' of undefined
    at Object.initActions (http://127.0.0.1:8005/static/framework/conf/resource-type-registry.service.js:265:42)
    at http://127.0.0.1:8005/static/dashboard/project/search/table/search-table.controller.js:114:18
    at Array.forEach (native)
    at pluginsUpdated (http://127.0.0.1:8005/static/dashboard/project/search/table/search-table.controller.js:113:33)
    at Scope.$emit (http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:14798:33)
    at pluginsReceived (http://127.0.0.1:8005/static/dashboard/project/search/settings/search-settings.service.js:108:15)
    at http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:9442:11
    at processQueue (http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:13300:27)
    at http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:13316:27
    at Scope.$eval (http://127.0.0.1:8005/static/horizon/lib/angular/angular.js:14552:28)

Found this when testing the hypervisor plugin for searchlight: https://review.openstack.org/#/c/297586/7

Tags: angularjs
Travis Tripp (travis-tripp)
Changed in searchlight:
assignee: nobody → Travis Tripp (travis-tripp)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to searchlight-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/313798

Changed in searchlight:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to searchlight-ui (master)

Reviewed: https://review.openstack.org/313798
Committed: https://git.openstack.org/cgit/openstack/searchlight-ui/commit/?id=3899031b679876362d9e453db51687f21d572cbf
Submitter: Jenkins
Branch: master

commit 3899031b679876362d9e453db51687f21d572cbf
Author: Travis Tripp <email address hidden>
Date: Fri May 6 17:28:26 2016 -0600

    Add graceful handling for missing registry actions

    The action registry threw an error when OS::Nova::Hypervisor [0]
    wasn't found. This may get fixed in horizon, but we should
    do a little protective coding here so that the UI handles
    this without completely barfing.

    There may need to be follow up patches to more gracefully handle
    other registry usages.

    [0] https://review.openstack.org/#/c/297586/7

    Change-Id: I4124fe2e510d82d674b1810294929642354faa03
    Partial-Bug: 1579262

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317619

Changed in horizon:
status: New → In Progress
Matt Borland (palecrow)
Changed in horizon:
importance: Undecided → High
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/317619
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=1d60ffd5d017c82ea3eeb9b429e0ee5030f5891c
Submitter: Jenkins
Branch: master

commit 1d60ffd5d017c82ea3eeb9b429e0ee5030f5891c
Author: Matt Borland <email address hidden>
Date: Tue May 17 10:38:17 2016 -0600

    Added safety check to initActions so unregistered types pass

    This patch adds a basic safety check to ensure that initScope doesn't throw
    errors when an unregistered type is passed in. Added a test that demonstrates
    this as well.

    Change-Id: Ifdefaa3cc0b792221323136de8b8bd0eb76d7486
    Closes-Bug: 1579262

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 10.0.0.0b2

This issue was fixed in the openstack/horizon 10.0.0.0b2 development milestone.

Travis Tripp (travis-tripp)
Changed in searchlight:
status: In Progress → Fix Released
milestone: none → newton-1
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.