Cinder

Cheesecake APIs are not supported by policy.json and code

Bug #1578722 reported by Mitsuhiro Tanino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
Mitsuhiro Tanino
Cinder newton-1 "n1"

Bug Description

After introducing replication v2.1(Cheesecake), these API were deprecated. We should remove them from policy.json.

    "volume:enable_replication": "rule:admin_api",
    "volume:disable_replication": "rule:admin_api",
    "volume:failover_replication": "rule:admin_api",
    "volume:list_replication_targets": "rule:admin_api",

Also newly added APIs are needed to add policy.json and the code to support applying this policy action.

    "volume:failover_host": "rule:admin_api",
    "volume:freeze_host": "rule:admin_api",
    "volume:thaw_host": "rule:admin_api",

Mitsuhiro Tanino (mitsuhiro-tanino)
Changed in cinder:
importance: Undecided → Low
Jay Bryant (jsbryant)
Changed in cinder:
milestone: none → newton-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/313124

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/313124
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=01c6f681f9f4c0e81c1c1ece61ad812f4cb7e6bc
Submitter: Jenkins
Branch: master

commit 01c6f681f9f4c0e81c1c1ece61ad812f4cb7e6bc
Author: Mitsuhiro Tanino <email address hidden>
Date: Thu May 5 12:31:00 2016 -0400

    Add Cheesecake APIs to policy.json file

    These replication v2.1 APIs are not enforced by the
    cinder policy.json file. This patch adds policy and
    the code to support applying this policy action.

      "volume:failover_host": "rule:admin_api",
      "volume:freeze_host": "rule:admin_api",
      "volume:thaw_host": "rule:admin_api",

    Also these methods create a completely new context
    instead of doing context.elevated(). It's better
    to preserve the information that already there.

    Change-Id: Ib577e902cda634ae2bd813edd9e39e022f23fde1
    Closes-Bug: #1578722

Changed in cinder:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/cinder 9.0.0.0b1

This issue was fixed in the openstack/cinder 9.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.