The influxdb_accumulator filter can generate incorrect data

Bug #1572631 reported by Simon Pasquier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StackLight
Fix Released
Medium
Simon Pasquier

Bug Description

The filter doesn't check for empty tag values which aren't allowed by the InfluxDB protocol.

For example:

sample,metadata.host=network.node-6.test.domain.local,metadata.name=,metadata.status=DOWN,meter=port,project_id=5f35ff51f94e433ca5bd07dc3aedb05a,resource_id=09cc2e19-e6b1-4ac5-a802-6b9e185e0061,source=openstack type="gauge",value=1.000000,message_id="06084676-06e2-11e6-a7ea-1632710d7aa5",timestamp="2016-04-20 10:24:11.493052",unit="port" 1461147851493100032

The metadata.name tag is empty and eventually the InfluxDB HTTP output plugin will try to send the request forever because the InfluxDB server replies with a 400 response code.

Tags: collector
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-plugin-lma-collector (master)

Fix proposed to branch: master
Review: https://review.openstack.org/308841

Changed in lma-toolchain:
assignee: LMA-Toolchain Fuel Plugins (mos-lma-toolchain) → Simon Pasquier (simon-pasquier)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-plugin-lma-collector (master)

Reviewed: https://review.openstack.org/308841
Committed: https://git.openstack.org/cgit/openstack/fuel-plugin-lma-collector/commit/?id=76ff4b7dcdbd0ee9300fffc179af50d992b59b01
Submitter: Jenkins
Branch: master

commit 76ff4b7dcdbd0ee9300fffc179af50d992b59b01
Author: Simon Pasquier <email address hidden>
Date: Thu Apr 21 10:44:26 2016 +0200

    Prevent empty tag names and values for InfluxDB

    Change-Id: Ide0a52d63f5e6385997455e81899f76f8b5a0829
    Closes-Bug: #1572631

Changed in lma-toolchain:
status: In Progress → Fix Committed
Changed in lma-toolchain:
milestone: 1.0.0 → 0.10.0
Changed in lma-toolchain:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.