kolla

Remove check for config files to verify MountFlags

Bug #1571281 reported by Swapnil Kulkarni
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Critical
Unassigned
kolla newton-1 "n1"
Liberty
Fix Released
Critical
Unassigned
kolla 1.1.0 "liberty"
Mitaka
Fix Released
Critical
Unassigned
kolla 2.0.0 "mitaka 2.0.0"

Bug Description

I created a file /etc/systemd/system/docker.service.d/non-kolla.conf here is the result of systemctl cat docker http://paste.fedoraproject.org/356655/14608610/

then I /etc/systemd/system/docker.service.d/akolla.conf here is the result of systemctl cat docker http://paste.fedoraproject.org/356656/86107714/

when you do daemon-reload and restart it always picks up files alphabetically :)

Check MountFlags option with systemd rather than with
configuration files which can be overriden with
different ones.

Swapnil Kulkarni (coolsvap-deactivatedaccount)
Changed in kolla:
milestone: none → newton-1
OpenStack Infra (hudson-openstack)
Changed in kolla:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/306792

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on kolla (stable/mitaka)

Change abandoned by Swapnil Kulkarni (coolsvap) (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/306792
Reason: I will cherry pick once https://review.openstack.org/305611 is merged

Revision history for this message
Swapnil Kulkarni (coolsvap-deactivatedaccount) wrote :

Change https://review.openstack.org/305611 needs to cherrypicked and might have some conflicts which need to be resolved in order to be merged in master.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.openstack.org/305611
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=47894bb05f8446d8db645dcd6dc580d5d4ae64d2
Submitter: Jenkins
Branch: master

commit 47894bb05f8446d8db645dcd6dc580d5d4ae64d2
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Thu Apr 14 10:44:48 2016 +0530

    Remove check for config files to verify MountFlags

    Check MountFlags option with systemd rather than with
    configuration files which can be overriden with
    different ones.

    Co-Authored-By: Jeffrey Zhang <jeffrey.zhang@99cloud.net>
    Change-Id: Ifa4ce62372af3fe75a66b45c8e7cf9ac9f9c2415
    Closes-Bug: #1571281

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/liberty)

Reviewed: https://review.openstack.org/308759
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=908fed8c02fb1e04e55a8e0b991c85fc3f94c588
Submitter: Jenkins
Branch: stable/liberty

commit 908fed8c02fb1e04e55a8e0b991c85fc3f94c588
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Thu Apr 14 10:44:48 2016 +0530

    Remove check for config files to verify MountFlags

    Check MountFlags option with systemd rather than with
    configuration files which can be overriden with
    different ones.

    Co-Authored-By: Jeffrey Zhang <jeffrey.zhang@99cloud.net>
    Change-Id: Ifa4ce62372af3fe75a66b45c8e7cf9ac9f9c2415
    Closes-Bug: #1571281
    (cherry picked from commit 47894bb05f8446d8db645dcd6dc580d5d4ae64d2)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/mitaka)

Reviewed: https://review.openstack.org/306792
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=576764e99cf2c6e4d20f7751ef8f02fe3dce6764
Submitter: Jenkins
Branch: stable/mitaka

commit 576764e99cf2c6e4d20f7751ef8f02fe3dce6764
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Sun Apr 17 08:54:37 2016 +0530

    Remove check for config files to verify MountFlags

    Check MountFlags option with systemd rather than with
    configuration files which can be overriden with
    different ones.

    Co-Authored-By: Jeffrey Zhang <jeffrey.zhang@99cloud.net>
    Change-Id: Ifa4ce62372af3fe75a66b45c8e7cf9ac9f9c2415
    Closes-Bug: #1571281
    (cherry picked from commit 47894bb05f8446d8db645dcd6dc580d5d4ae64d2)

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 2.0.0

This issue was fixed in the openstack/kolla 2.0.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 1.1.0

This issue was fixed in the openstack/kolla 1.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/kolla 3.0.0.0b1

This issue was fixed in the openstack/kolla 3.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.