Close Dash Page header "extra" panel when selecting an option on the dash primary filter

Bug #1569498 reported by Kyle Nitzsche
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Medium
Unassigned
canonical-scopes-project
New
Undecided
Unassigned
unity8 (Ubuntu)
Fix Released
Medium
Josh Arenson

Bug Description

We should close the Dash Page header extra panel (i.e. the one that contains old searches/departments/primary navigation filter) when we have a primary navigation filter and one of the filters of the option selector is selected.

We will only allow "sigle selection filters" in there, so the single selection option or a radio group (when/if we have it), so we can perfectly close the panel when something on the filter has been selected.

Suggested solution to the bug by Albert: FilterWidget needs to have a "clicked/activated" signal that the FilterOptionSelection will emit and the PageHeaderExtraPanel will receive and then emit another signal so that it gets closed, i.e. something similar to what dashNavigation does with onLeafClicked

**********************************************
Old description, comments up to #5 relate to this description

When you are using an option filter as the primary navigation widget, usually dismissing the filter widget by tapping results causes a result preview to display, but the user really wants to see all results and only dismiss the filter overly.

You can see this in the attached fake 500px click:

1) tap the search magnifying glass icon to display the filter overlay
2) expand "Discover" (that is the title of the nav filter in this case
3) select any option under Discover
4) collapse "Discover" so that the overlay is small enough that some results are visible
5) tap results area to dismiss the overlay

What happens: The preview for the result you tapped displays

What was expected: the filter overlay disappears showing results

Related branches

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :
Revision history for this message
Albert Astals Cid (aacid) wrote :

This is how the panel always has worked, if you go to a scope that has departments instead of a primary filter, you'll see it behaves the same way.

If you disagree with this behaviour please ask design (probably Patricia) about it.

Changed in unity8 (Ubuntu):
status: New → Invalid
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Albert,

I set this to New again in unity8 because I am not 100% sure you are correct.

For example the News Scope has departments. When you select a department, the department selection gui disappears and the new department results display. But not in the case of the option filter as primary nav filter. In this case, when you select a different filter option, the filter selection overlay does not disappear. So the user has no option to tap in the result area, and this almost always takes them to a result preview.

Changed in unity8 (Ubuntu):
status: Invalid → New
Revision history for this message
Albert Astals Cid (aacid) wrote :

Your bug says "dismissing primary nav filter shows a preview" and i say "dismissing a open deparment filter shows a preview too", and i am right, that's why i closed the bug.

Now I understand that when using departments selecting a department closes the list. That is something we can't do for primary fitler since there's no "activate this" on primary filters, they can be ranges, multi selection, etc. that don't have a press on screen that can be identified as "i'm done".

But in my opinion that's a design problem with having filters there instead of on the proper place for filters, so you'll have to involve people from design so that they find a way around it.

As it stands i disagree this is a bug in the implementation of dismissing the panel when there is a primary navigation filters since it behaves the same way dismissing works when there's no primary navigation filter.

Changed in unity8 (Ubuntu):
status: New → Incomplete
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

As discussed in our hangout, my understanding (about which I am not 100% certain) is that only an option selector filter set to single select can be the primary navigation. So, when the user selects a new option, the widget & overlay should disappear (just as it does with departments).

summary: - dismissing primary nav filter shows a preview
+ Close Dash "extra" panel when selecting an option on the dash primary
+ filter
summary: - Close Dash "extra" panel when selecting an option on the dash primary
- filter
+ Close Dash Page header "extra" panel when selecting an option on the
+ dash primary filter
description: updated
Changed in unity8 (Ubuntu):
status: Incomplete → Triaged
assignee: nobody → Josh Arenson (josharenson)
importance: Undecided → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.12+16.10.20160527-0ubuntu1

---------------
unity8 (8.12+16.10.20160527-0ubuntu1) yakkety; urgency=medium

  [ Albert Astals Cid ]
  * Activate on click for SimpleMessages (LP: #1421696)
  * Add override
  * Change the art back to the cardData value if it changes from broken
    to valid image (LP: #1533577)
  * Concierge mode generated code optimization
  * Don't use context properties but properties of the delegates
  * Listen to contentItem::widthChanged instead of
    Flickable::contentWidthChanged (LP: #1565763)
  * Make some AP code faster
  * Make tests a bit more stable
  * Make unity8 and unity8-dash handle termination signals
  * Remove workaround not needed anymore (LP: #1475643)
  * Resolve cardArtStyle on compile time
  * Set the theme earlier (LP: #1574048)

  [ Albert Astals Cid, Daniel d'Andrada ]
  * Remove DirectionalDragArea and libs/UbuntuGestures and port to SDK
    equivalents

  [ Andrea Cimitan ]
  * Hide the preview review input field when a rating is required (LP:
    #1541971)

  [ CI Train Bot ]
  * Resync trunk.

  [ Daniel d'Andrada ]
  * Fix DragHandle so it works in all directions
  * Support animated cursors
  * WindowInputMonitor - also map Qt::Key_HomePage to our home key
  * plugins/Cursor: properly register to the screen's QPlatformCursor
    when screen changes (LP: #1579742)

  [ Josh Arenson ]
  * Close the PageHeaderExtraPanel when a filter option is selected (LP:
    #1569498)
  * Wrap primaryFilter in a flickable to make it behave nicely. (LP:
    #1569492)

  [ Lukáš Tinkl ]
  * First snap decision should always be expanded, unless user decides
    otherwise (LP: #1580090, #1575045)
  * Fullscreen notification bug fixes (LP: #1583944, #1581498, #1422711)
  * Implement maximizing windows horizontally/vertically
  * Lock the session when putting the laptop into sleep (LP: #1581063)

  [ Lukáš Tinkl, Michael Terry ]
  * With a maximized window, "dragging" the panel down should restore it

  [ Michael Terry ]
  * Change some dash button colors from orange to green. (LP: #1581047)
  * Use PageHeader instead Ambiance's PageHeadStyle
  * Use new setTimeZone method to set user-friendly timezone name in the
    wizard. (LP: #1566295)

  [ Michael Zanetti ]
  * Remove the background dimming when the launcher is revealed by a
    drag (LP: #1575137)
  * reenable or drop disabled tests

 -- Michael Terry <email address hidden> Fri, 27 May 2016 13:54:44 +0000

Changed in unity8 (Ubuntu):
status: Triaged → Fix Released
Changed in canonical-devices-system-image:
status: New → Fix Committed
importance: Undecided → Medium
milestone: none → 12
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.