widelands

Ware statistic: Clicking the first time on an icon the graph flickers

Bug #1566167 reported by kaputtnik
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
widelands
Fix Released
Medium
Unassigned
widelands build20-rc1

Bug Description

If one clicks on an icon in ware statistic window the graph some times overflows the drawing area for a very short time and then gets adjusted to fit.

Attached a save game where this happens: Open Ware statistic and toggle the Bread button.

Related branches

lp://staging/~widelands-dev/widelands/bug-1573057-graph-relative-plotmode
TiborB: Approve
kaputtnik (community): Approve (testing)
Diff: 918 lines (+231/-248)
6 files modified
src/logic/cmd_calculate_statistics.cc (+1/-1)
src/logic/constants.h (+4/-2)
src/wui/general_statistics_menu.cc (+3/-3)
src/wui/plot_area.cc (+176/-203)
src/wui/plot_area.h (+35/-27)
src/wui/ware_statistics_menu.cc (+12/-12)
Revision history for this message
kaputtnik (franku) wrote :
Revision history for this message
GunChleoc (gunchleoc) wrote :

I have seen this too.

Maybe related: https://bugs.launchpad.net/widelands/+bug/1566037

Changed in widelands:
status: New → Confirmed
GunChleoc (gunchleoc)
Changed in widelands:
status: Confirmed → In Progress
assignee: nobody → GunChleoc (gunchleoc)
kaputtnik (franku)
Changed in widelands:
status: In Progress → Fix Committed
assignee: GunChleoc (gunchleoc) → nobody
GunChleoc (gunchleoc)
tags: added: graphics
removed: graphic
GunChleoc (gunchleoc)
Changed in widelands:
status: Fix Committed → Fix Released
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build19-rc1.

kaputtnik (franku)
Changed in widelands:
status: Fix Released → Confirmed
milestone: build19-rc1 → build20-rc1
Revision history for this message
kaputtnik (franku) wrote :

This is up again. I encounter this in current trunk (r8377) for 'statistic -> ware statistic -> stock tab' when playing this savegame: https://bugs.launchpad.net/widelands/+bug/1690519/+attachment/4895312/+files/wl_autosave_00.wgf

It happens mostly when 'Beer' is clicked.

Revision history for this message
GunChleoc (gunchleoc) wrote :

It's not just the flicker, but also the width of the line itself.

I'm guessing that we are having an int/float problem here.

Revision history for this message
kaputtnik (franku) wrote :

I think the bold part of the line comes from close up and down, because the first and last part (on the left and right) looks ok for me, if you mentioned the bold part in the middle.

Revision history for this message
GunChleoc (gunchleoc) wrote :

You're right, it's just tight lines.

I did notice one other thing though: It doesn't flicker when the game is paused.

Revision history for this message
kaputtnik (franku) wrote :

I get some memory leaks with ASAN when using the save game from #4. I think this is related to WuiPlotArea::register_plot_data.

SUMMARY: AddressSanitizer: 9848 byte(s) leaked in 353 allocation(s).

GunChleoc (gunchleoc)
tags: added: asan
Revision history for this message
GunChleoc (gunchleoc) wrote :

The memory leak is gone, so I'm setting this to fix committed.

Changed in widelands:
status: Confirmed → Fix Committed
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.