_round_timestamp called too often
Bug #1562820 reported by
gordon chung
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Gnocchi |
Fix Released
|
High
|
gordon chung |
Bug Description
performance degradation occurs on metricd workers as the system accumulates more data. when profiling, round_timestamp is called tens of thousands or hundreds of thousands of times to process each metric. it represents the majority of workload
Changed in gnocchi: | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in gnocchi: | |
milestone: | none → 2.1.0 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The way you wrote that report sounds like _round_timestamp() is getting slower and slower, which is more than unlikely.
It's true that 33% of the time is spent in _round_timestamp, which makes sense since it's called 100k time, which also "make sense" since it's used by groupby(). I imagine the time series tested had a few thousand datapoints?
I wonder if groupby() is not called on too many timestamps here. Unless you try to re-aggregate the *whole* time serie – which is *very* unlikely if you appened a few datapoints at the end, it should not be called so often.