Data race in github.com/juju/juju/worker/environ

Bug #1561555 reported by Cheryl Jennings
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
Critical
Ian Booth

Bug Description

As seen in: http://reports.vapour.ws/releases/3813/job/run-unit-tests-race/attempt/1216

WARNING: DATA RACE
Read by goroutine 7:
  github.com/juju/juju/worker/environ_test.(*mockEnviron).Config()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/fixture_test.go:130 +0xa6
  github.com/juju/juju/worker/environ_test.func·012()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/environ_test.go:210 +0x52d
  github.com/juju/juju/worker/environ_test.(*fixture).Run()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/fixture_test.go:34 +0x1be
  github.com/juju/juju/worker/environ_test.(*TrackerSuite).TestWatchedModelConfigUpdates()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/environ_test.go:222 +0x18c
  runtime.call16()
      /usr/lib/go/src/pkg/runtime/asm_amd64.s:338 +0x31
  reflect.Value.Call()
      /usr/lib/go/src/pkg/reflect/value.go:345 +0xaa
  gopkg.in/check%2ev1.func·003()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/check.go:772 +0x504
  gopkg.in/check%2ev1.func·001()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/check.go:666 +0xf3

Previous write by goroutine 15:
  github.com/juju/juju/worker/environ_test.(*mockEnviron).SetConfig()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/fixture_test.go:138 +0x13d
  github.com/juju/juju/worker/environ.(*Tracker).loop()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/environ.go:121 +0x3a3
  github.com/juju/juju/worker/environ.*Tracker.(github.com/juju/juju/worker/environ.loop)·fm()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/environ.go:84 +0x45
  github.com/juju/juju/worker/catacomb.func·003()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/catacomb/catacomb.go:115 +0xcd

Goroutine 7 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/check.go:667 +0x529
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/check.go:804 +0x168
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/check.go:809 +0x3e
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/check.go:615 +0x44a
  gopkg.in/check%2ev1.Run()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/run.go:92 +0x56
  gopkg.in/check%2ev1.RunAll()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/run.go:84 +0x111
  gopkg.in/check%2ev1.TestingT()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/run.go:72 +0x4d6
  github.com/juju/juju/worker/environ_test.TestPackage()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/package_test.go:13 +0x34
  testing.tRunner()
      /usr/lib/go/src/pkg/testing/testing.go:391 +0x10f

Goroutine 15 (running) created at:
  github.com/juju/juju/worker/catacomb.Invoke()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/catacomb/catacomb.go:116 +0x515
  github.com/juju/juju/worker/environ.NewTracker()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/environ.go:85 +0x2dc
  github.com/juju/juju/worker/environ_test.func·012()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/environ_test.go:194 +0xa9
  github.com/juju/juju/worker/environ_test.(*fixture).Run()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/fixture_test.go:34 +0x1be
  github.com/juju/juju/worker/environ_test.(*TrackerSuite).TestWatchedModelConfigUpdates()
      /home/ubuntu/juju-core_2.0-beta3/src/github.com/juju/juju/worker/environ/environ_test.go:222 +0x18c
  runtime.call16()
      /usr/lib/go/src/pkg/runtime/asm_amd64.s:338 +0x31
  reflect.Value.Call()
      /usr/lib/go/src/pkg/reflect/value.go:345 +0xaa
  gopkg.in/check%2ev1.func·003()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/check.go:772 +0x504
  gopkg.in/check%2ev1.func·001()
      /home/ubuntu/juju-core_2.0-beta3/src/gopkg.in/check.v1/check.go:666 +0xf3
==================
OK: 14 passed
PASS
Found 1 data race(s)
FAIL github.com/juju/juju/worker/environ 2.016s

tags: added: blocker ci
Revision history for this message
Ian Booth (wallyworld) wrote :
Changed in juju-core:
assignee: nobody → Ian Booth (wallyworld)
status: Triaged → In Progress
Ian Booth (wallyworld)
Changed in juju-core:
status: In Progress → Fix Committed
Aaron Bentley (abentley)
tags: added: tech-debt
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
affects: juju-core → juju
Changed in juju:
milestone: 2.0-beta3 → none
milestone: none → 2.0-beta3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.