TestInvalidFileFormat fails on windows because of /

Bug #1558087 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
Critical
Casey Marshall

Bug Description

As seen in
    http://reports.vapour.ws/releases/issue/56e960f0749a5630fd107ba7

TestInvalidFileFormat fails on windows because of /

deploy_test.go:130:
    c.Assert(err, gc.ErrorMatches,
        `invalid charm or bundle provided at ".*`+filepath.FromSlash("/bundle.yaml")+`"`)
... error string = "invalid charm or bundle provided at \"c:\\\\users\\\\admini~1\\\\appdata\\\\local\\\\temp\\\\tmp1vd0x9\\\\gogo\\\\tmp-juju-testfwmz_y\\\\check-2208715849129672229\\\\167\\\\bundle.yaml\""
... regex string = "invalid charm or bundle provided at \".*\\bundle.yaml\""

Curtis Hovey (sinzui)
Changed in juju-core:
status: New → Incomplete
Revision history for this message
Curtis Hovey (sinzui) wrote :

This issue has mutated since it was first seen. An effort was made to fix this fail, but it is not complete.

Revision history for this message
Casey Marshall (cmars) wrote :

Fixed in model-acls. This test failure also currently affects master FWIW:

PS C:\Users\Administrator\golang\src\github.com\juju\juju> go test ./cmd/juju/service --gocheck.f=Invalid

----------------------------------------------------------------------
FAIL: deploy_test.go:124: DeploySuite.TestInvalidFileFormat

[snip]

deploy_test.go:130:
    c.Assert(err, gc.ErrorMatches,
        `invalid charm or bundle provided at ".*`+filepath.FromSlash("/bundle.yaml")+`"`)
... error string = "invalid charm or bundle provided at \"C:\\\\Users\\\\ADMINI~1\\\\AppData\\\\Local\\\\Temp\\\\2\\\\ch
eck-7327674107095723743\\\\7\\\\bundle.yaml\""
... regex string = "invalid charm or bundle provided at \".*\\bundle.yaml\""

[snip]

OOPS: 13 passed, 1 FAILED
--- FAIL: TestPackage (16.17 seconds)
FAIL
FAIL github.com/juju/juju/cmd/juju/service 18.618s
PS C:\Users\Administrator\golang\src\github.com\juju\juju> git log -1 --pretty=format:%H
45cc6aa81dc491d292b0e5731652017409e71f1c
PS C:\Users\Administrator\golang\src\github.com\juju\juju>

I have an approved fix for it, https://github.com/juju/juju/pull/4756, but I can't land it because master is currently blocked.

Changed in juju-core:
assignee: nobody → Casey Marshall (cmars)
milestone: none → 2.0-beta3
status: Incomplete → In Progress
Curtis Hovey (sinzui)
Changed in juju-core:
importance: Undecided → Critical
tags: added: blocker
Casey Marshall (cmars)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
tags: added: 2.0-count
affects: juju-core → juju
Changed in juju:
milestone: 2.0-beta3 → none
milestone: none → 2.0-beta3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.