MAAS

Deleting a fabric shows weird UI & sends you back to the node listing page

Bug #1557582 reported by Andres Rodriguez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
LaMont Jones
MAAS 2.0.0

Bug Description

Trying to delete a fabric shows a weird UI. See attached screenshot.

After deleting, it sends you to the Node Listing page rather than the Networks page.

See original description
Tags: ui

Related branches

lp://staging/~lamont/maas/delete-fabric-domain-ui-cleanup
Blake Rouse (community): Approve
Diff: 366 lines (+205/-63)
8 files modified
src/maasserver/api/dnsresourcerecords.py (+3/-0)
src/maasserver/api/tests/test_dnsresourcerecords.py (+35/-8)
src/maasserver/static/js/angular/controllers/domain_details.js (+9/-0)
src/maasserver/static/js/angular/controllers/fabric_details.js (+9/-0)
src/maasserver/static/js/angular/controllers/tests/test_domain_details.js (+45/-11)
src/maasserver/static/js/angular/controllers/tests/test_fabric_details.js (+45/-11)
src/maasserver/static/partials/domain-details.html (+30/-29)
src/maasserver/static/partials/fabric-details.html (+29/-4)
Revision history for this message
Andres Rodriguez (andreserl) wrote :
summary: - Deleting a fabric shows weird UI.
+ Deleting a fabric shows weird UI & sends you back to the node listing
+ page
description: updated
Revision history for this message
Andres Rodriguez (andreserl) wrote :
Revision history for this message
LaMont Jones (lamont) wrote :

This is one of several places where this is found (and where it was copied from...)

-tigernut 353 : grep 'Are you sure you want to ' * | sed 's/ //g'
domain-details.html:Are you sure you want to delete this domain?
fabric-details.html:Are you sure you want to delete this fabric?
node-details.html: <p><span class="icon warning margin-right--ten"></span> Are you sure you want to remove this {$ getRemoveTypeText(interface) $}?</p>
node-details.html:<p><span class="icon warning margin-right--ten"></span> Are you sure you want to unmount this filesystem?</p>
node-details.html:<p><span class="icon warning margin-right--ten"></span> Are you sure you want to remove this {$ getRemoveTypeText(filesystem) $}?</p>
node-details.html:<p><span class="icon warning margin-right--ten"></span> Are you sure you want to delete this cache set?</p>
node-details.html:<p><span class="icon warning margin-right--ten"></span> Are you sure you want to unformat this '{$ item.fstype $}' filesystem?</p>
node-details.html:<p><span class="icon warning margin-right--ten"></span> Are you sure you want to remove this {$ getRemoveTypeText(item) $}?</p>
space-details.html:Are you sure you want to delete this space?
subnet-details.html:<p class="page-header__feedback-message warning">Are you sure you want to remove this subnet release all IP addresses assigned within its range?</p>
subnet-details.html:<p class="page-header__feedback-message warning">Are you sure you want to remove this subnet?</p>

Revision history for this message
Blake Rouse (blake-rouse) wrote :

Lamont is correct, this should show this message. But the CSS is way wrong.

tags: added: ui
Changed in maas:
importance: Undecided → Critical
milestone: none → 2.0.0
status: New → Triaged
Andres Rodriguez (andreserl)
Changed in maas:
assignee: nobody → LaMont Jones (lamont)
Blake Rouse (blake-rouse)
Changed in maas:
status: Triaged → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.