Murano

dashboard: string concatenation makes translators difficult to control word order in PasswordField

Bug #1556403 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Medium
Kirill Zaitsev
Murano mitaka-rc1 "RC1"

Bug Description

During translations,

murano-dashboard PasswordField aggressively uses string concatenations and it makes translator difficult to control word order in a sentence. Especially it is a bad idea to concatenate a partial string to some sentence.
From the i18n perspective, I would suggest to add a separate sentence at least.

https://github.com/openstack/murano-dashboard/blob/4e7f649ca4de6d95314c27ce7fe9adcdda5b673a/muranodashboard/dynamic_ui/fields.py#L272-L274

Tags: i18n
Akihiro Motoki (amotoki)
Changed in murano:
assignee: nobody → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/292082

Changed in murano:
status: New → In Progress
Kirill Zaitsev (kzaitsev)
Changed in murano:
assignee: Akihiro Motoki (amotoki) → Kirill Zaitsev (kzaitsev)
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Can we have a fix before RC1?
From i18n perspecitve, the current string is hard to be translated into a natural sentence in some language due to string concatenation.

Revision history for this message
Kirill Zaitsev (kzaitsev) wrote :

Pls review the latest patch. I'm sure we'll have this in before rc1

Kirill Zaitsev (kzaitsev)
Changed in murano:
importance: Undecided → Low
milestone: none → mitaka-rc1
importance: Low → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/292082
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=81bffef47da9bb69c8baa93ddd1393dbf16e4d6c
Submitter: Jenkins
Branch: master

commit 81bffef47da9bb69c8baa93ddd1393dbf16e4d6c
Author: Akihiro Motoki <email address hidden>
Date: Sat Mar 12 19:35:09 2016 +0900

    Cleanup PasswordField.init and remove i18n-nonfriendly strings

    PasswordField __init__ contains string concatenations
    which make translations difficult.

    This commit leaves default message in case there are no custom
    validators and adds a simple generic help text for the password fields in
    case there are custom validators and no help_text is supplied, since the
    exact contains are difficult to obtain (in case of regexp validators).

    Resulting strings marked for translation are clean and should allow i18n
    team to have better control over the flow of translated text.

    Co-Authored-By: Kirill Zaitsev <email address hidden>
    Closes-Bug: #1556403
    Change-Id: I64f9fc4006f44ba27e776a325ff664316f3ec2ec

Changed in murano:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.