neutron

description association proxy shared between all standard attrs

Bug #1553689 reported by Kevin Benton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Kevin Benton
neutron mitaka-rc1 "RC1"

Bug Description

The association proxy added for the description on all standard attribute resources was being shared between all standard attributes since it was defined on the class that they all inherit. This meant that the first model to load would become the reference and break filtering for all of the others.

This was causing unit tests to sporadically fail because it depended on the model load order of each worker which depended on the order of tests they executed.

See original description
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/288999

Changed in neutron:
assignee: nobody → Kevin Benton (kevinbenton)
status: New → In Progress
Kevin Benton (kevinbenton)
description: updated
Changed in neutron:
milestone: none → mitaka-rc1
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/288999
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=284f507adaa2af7691e49327cdfc2baba9268455
Submitter: Jenkins
Branch: master

commit 284f507adaa2af7691e49327cdfc2baba9268455
Author: Kevin Benton <email address hidden>
Date: Sun Mar 6 02:24:14 2016 -0800

    Delay description association proxy construction

    Association proxies cannot be constructed in the mixin because they
    will be shared between all models that inherit from it. This means
    they all share one and it will effectively be broken for all but the
    first to load it.

    This changes it to a declared attr like the others to make sure it's
    not constructed until each model inherits from it.

    Change-Id: I3e1aa21cd02c0f116cc6dee5e0577988ec37f767
    Closes-Bug: #1553689

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/neutron 8.0.0.0rc1

This issue was fixed in the openstack/neutron 8.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.