Juniper Openstack

BGPaaS: agent not able to parse IP address when not set in BGPaaS object

Bug #1547263 reported by amit surana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.0
Fix Committed
High
Manish Singh
Juniper Openstack r3.0.2.0
Trunk
Fix Committed
High
Manish Singh
Juniper Openstack r3.1.0.0-fcs

Bug Description

Agent seems to be parsing the bgp-as-a-service node rather than the bgp-router node to extract the IP address. This causes a problem when IP address isn't explicitly set on the BGPaaS object.

2016-02-18 15:07:35.514 XmppTxStream: Sent xmpp message to: 172.16.180.11 Port 52006 Size: 1446 Packet: <?xml version="1.0"?> <iq type="set" <email address hidden>" to="default-global-system-config:csol2-node11/config"> <config> <update> <node type="bgp-as-a-service"> <name>default-domain:bgp-test:bgp-noip</name> <autonomous-system>6555</autonomous-system> <bgpaas-session-attributes></bgpaas-session-attributes> <id-perms> <permissions> <owner>cloud-admin</owner> <owner-access>7</owner-access> <group>cloud-admin-group</group> <group-access>7</group-access> <other-access>7</other-access> </permissions> <uuid> <uuid-mslong>824251293522020408</uuid-mslong> <uuid-lslong>11339229546096191126</uuid-lslong> </uuid> <enable>true</enable> <created>2016-02-18T23:07:35</created> <last-modified>2016-02-18T23:07:35</last-modified> <description></description> <user-visible>true</user-visible> <creator></creator> </id-perms> <perms2> <owner></owner> <owner-access>7</owner-access> <global-access>0</global-access> </perms2> <display-name>bgp-noip</display-name> </node> <link> <node type="bgp-as-a-service"> <name>default-domain:bgp-test:bgp-noip</name> </node> <node type="virtual-machine-interface"> <name>default-domain:bgp-test:vmi-x1-_0_0</name> </node> <metadata type="bgpaas-virtual-machine-interface" /> </link> </update> </config> </iq> $ controller/src/xmpp/xmpp_connection.cc 209
2016-02-18 15:07:35.607 XmppTxStream: Sent xmpp message to: 172.16.180.11 Port 52006 Size: 1435 Packet: <?xml version="1.0"?> <iq type="set" <email address hidden>" to="default-global-system-config:csol2-node11/config"> <config> <update> <node type="bgp-router"> <name>default-domain:bgp-test:vn_private-x1-0:vn_private-x1-0:vmi-x1-_0_0</name> <bgp-router-parameters> <admin-down>false</admin-down> <vendor></vendor> <autonomous-system>6555</autonomous-system> <identifier>1.0.255.252</identifier> <address>1.0.255.252</address> <port>0</port> <source-port>50004</source-port> <hold-time>90</hold-time> <address-families /> <auth-data> <key-type></key-type> </auth-data> <local-autonomous-system>0</local-autonomous-system> <router-type>bgpaas-client</router-type> </bgp-router-parameters> </node> <link> <node type="bgp-as-a-service"> <name>default-domain:bgp-test:bgp-noip</name> </node> <node type="bgp-router"> <name>default-domain:bgp-test:vn_private-x1-0:vn_private-x1-0:vmi-x1-_0_0</name> </node> <metadata type="bgpaas-bgp-router" /> </link> <link> <node type="routing-instance"> <name>default-domain:bgp-test:vn_private-x1-0:vn_private-x1-0</name> </node> <node type="bgp-router"> <name>default-domain:bgp-test:vn_private-x1-0:vn_private-x1-0:vmi-x1-_0_0</name> </node> <metadata type="instance-bgp-router" /> </link> </update> </config> </iq> $ controller/src/xmpp/xmpp_connection.cc 209

Tags: bgpaas vrouter
amit surana (asurana-t)
tags: added: blocker
amit surana (asurana-t)
tags: removed: blocker
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/18289
Submitter: Manish Singh (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/18289
Committed: http://github.org/Juniper/contrail-controller/commit/e3bfa1c926e370c81066c9be4531031ee18a9fcf
Submitter: Zuul
Branch: R3.0

commit e3bfa1c926e370c81066c9be4531031ee18a9fcf
Author: Manish <email address hidden>
Date: Wed Mar 9 12:29:22 2016 +0530

Pick up bgp-as-service IP from bgp-router and not bgp-as-service node.
This allows to have no IP explicitly configured for bgp-as-service. The IP will
be of VM ip populated in bgp-router by schema.

Closes-bug: 1547263

Conflicts:
 src/vnsw/agent/test/SConscript
Change-Id: Ic1eee1fef5ccbd29c499bd81888083be0d3a0bd1

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/19574
Submitter: Manish Singh (<email address hidden>)

Revision history for this message
Rahul (rahuls) wrote :

Hi Rahul,

Fix for subject bug has been committed by Manish. Can you please make the corresponding UI changes (make IP address optional and move it to advanced section per Nischal's suggestion)?

thanks

amit.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.0

Review in progress for https://review.opencontrail.org/19624
Submitter: Siva Bavanasi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/19626
Submitter: Siva Bavanasi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/19574
Committed: http://github.org/Juniper/contrail-controller/commit/f2a7467caba85aa3592126b332dce72a4532ffad
Submitter: Zuul
Branch: master

commit f2a7467caba85aa3592126b332dce72a4532ffad
Author: Manish Singh <email address hidden>
Date: Sat Apr 23 17:44:35 2016 +0530

Pick up bgp-as-service IP from bgp-router and not bgp-as-service node.

This allows to have no IP explicitly configured for bgp-as-service. The IP will
be of VM ip populated in bgp-router by schema.

Closes-bug: 1547263

Conflicts:
src/vnsw/agent/test/SConscript

(cherry picked from commit e3bfa1c926e370c81066c9be4531031ee18a9fcf)

Conflicts:
src/vnsw/agent/test/test_cmn_util.h
src/vnsw/agent/test/test_util.cc
Change-Id: Ic1eee1fef5ccbd29c499bd81888083be0d3a0bd1

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/19624
Committed: http://github.org/Juniper/contrail-web-controller/commit/034f847eff1255600fb8470655576914a3fcb89a
Submitter: Zuul
Branch: R3.0

commit 034f847eff1255600fb8470655576914a3fcb89a
Author: Siva Bavanasi <email address hidden>
Date: Tue Apr 26 11:53:18 2016 +0530

Made IP_address as optional parameter in BGP As a Service

and also done below changes

1)Used display_name in BGP As a Service name binding and uses common methods
2)Used contrail methods to get cookie values

Change-Id: Iab411dc9994ceffd018f24b9da7a770ae7ed8e36
Related-bug: #1547263

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/19626
Committed: http://github.org/Juniper/contrail-web-controller/commit/722187c2df6c1dc688b278c5d9a2edd2190d5284
Submitter: Zuul
Branch: master

commit 722187c2df6c1dc688b278c5d9a2edd2190d5284
Author: Siva Bavanasi <email address hidden>
Date: Tue Apr 26 11:53:18 2016 +0530

Made IP_address as optional parameter in BGP As a Service

and also done below changes

1)Used display_name in BGP As a Service name binding and uses common methods
2)Used contrail methods to get cookie values

Change-Id: Iab411dc9994ceffd018f24b9da7a770ae7ed8e36
Related-bug: #1547263

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.