OpenStack Heat

Prev raw template and sync points not deleted for ROLLBACK

Bug #1544949 reported by Rakesh H S
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Rabi Mishra
OpenStack Heat newton-1 "n1"

Bug Description

When ROLLBACK is completed on a convergence enabled environment sync points and prev raw template is not deleted from DB.

In Convergence, once the stack is complete purge_db should be called, however for rollback purge_db is not getting called.

This is because when rollback is completed, it is being considered as a failed concurrent update https://github.com/openstack/heat/blob/master/heat/engine/stack.py#L1873

Since ROLLBACK is also an update and is handled by convergence code path, it should be fixed here:
https://github.com/openstack/heat/blob/master/heat/engine/stack.py#L802

See original description
Rakesh H S (rh-s)
Changed in heat:
assignee: nobody → Rakesh H S (rh-s)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/279519

Changed in heat:
status: New → In Progress
Sergey Kraynev (skraynev)
Changed in heat:
milestone: none → newton-1
importance: Undecided → Medium
OpenStack Infra (hudson-openstack)
Changed in heat:
assignee: Rakesh H S (rh-s) → Rabi Mishra (rabi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/279519
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c4fde708edbc400e3c44d7dcbfe131f9e987912f
Submitter: Jenkins
Branch: master

commit c4fde708edbc400e3c44d7dcbfe131f9e987912f
Author: Rakesh H S <email address hidden>
Date: Fri Feb 12 17:58:24 2016 +0530

    Convergence: Fix rollback considered as failed concurrent update

    In convergence, if stack state_set returns None, it indicates failed
    concurrent update.
    Fix rollback logic to follow convergence code path while saving the
    stack state in DB, so that convergence post stack action code is
    executed.

    Change-Id: I9c4910c9fa56aa0070c752fc419e5e5fa7f13e99
    Closes-Bug: #1544949

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/heat 7.0.0.0b1

This issue was fixed in the openstack/heat 7.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.