visual cleanup for convergence
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Bill Filler | ||
Ubuntu UX |
Triaged
|
High
|
Benjamin Keyser | ||
address-book-app (Ubuntu) |
Fix Released
|
High
|
Renato Araujo Oliveira Filho |
Bug Description
Information from design:
1) App should set preferred size to something that is good for desktop, i.e. that shows 2 columns width
2) in windowed mode - window decoration quickly switches between Contacts & Address Book in the naming on start of app
3) clean up empty state text, leave right hand column blank, no text at all accoding to Ben
4) google logo in 1st panel, empty list: import contacts is disappearing when you open the bottom edge briefly - should stay there until bottom edge is committed
5) when bottom edge is triggered and the background darkens, a white line is visible seemingly dividing the header and header sections; the white line seems to float on top of the bottom edge view. Should get rid of this
6) Contacts > new contact: “Add Field” should be “Add field” in the New contact view
7) Contacts > New contact - Font size for name and surname appears too large, make smaller
8) selected state in contact list view is super orange…and the names are purple -> massive no go; list item text should be aligned with new sdk guidelines as well as list item selection - use the selection rectangles instead of highlighting that olivier is using from the sdk presentation: https:/
- Settings:
9) default “Addressbook” should be “Address book” from one word to two words
10) wrong icon in the default address book, seem not to use the SURU icon theme, are icons in the selector needed at all? ‘Option Selector’ used to select address book (‘default address book, etc’) - Miss-aligned assets (icon, label, chevron). usage of wrong component in address book settings for selecting a local address book, it should be a list item and then a 2nd screen listing available accounts. Check with Ben on this. At miminum fix the alignment issues he is talking about.
Lower priority:
11) Settings panel in two column mode is wrong: contacts are still visible in left panel, should be list of settings in left hand panel with details in right panel
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 886 lines (+304/-125)19 files modifieddata/address-book-app.desktop.in.in (+0/-1)
src/app/addressbookapp.cpp (+1/-1)
src/imports/ABAdaptivePageLayout.qml (+50/-0)
src/imports/ABContactListPage.qml (+124/-59)
src/imports/ABContactViewPage.qml (+26/-23)
src/imports/ABMultiColumnEmptyState.qml (+30/-2)
src/imports/ABNewContactBottomEdge.qml (+2/-1)
src/imports/CMakeLists.txt (+1/-0)
src/imports/MainWindow.qml (+2/-3)
src/imports/Settings/SettingsDefaultSyncTarget.qml (+2/-7)
src/imports/Settings/SettingsPage.qml (+27/-9)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailNameEditor.qml (+1/-1)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactDetailSyncTargetEditor.qml (+1/-7)
src/imports/Ubuntu/AddressBook/ContactEditor/ContactEditorPage.qml (+1/-1)
src/imports/Ubuntu/AddressBook/ContactView/ContactViewPage.qml (+18/-0)
src/imports/Ubuntu/Contacts/ContactDelegate.qml (+1/-1)
src/imports/Ubuntu/Contacts/ContactListView.qml (+12/-6)
src/imports/Ubuntu/Contacts/ContactSimpleListView.qml (+0/-2)
src/imports/Ubuntu/Contacts/ListItemWithActions.qml (+5/-1)
Changed in address-book-app (Ubuntu): | |
assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in canonical-devices-system-image: | |
milestone: | none → ww08-2016 |
assignee: | nobody → Bill Filler (bfiller) |
importance: | Undecided → High |
status: | New → Confirmed |
description: | updated |
Changed in ubuntu-ux: | |
assignee: | nobody → Benjamin Keyser (bjkeyser) |
importance: | Undecided → High |
status: | New → Triaged |
Changed in canonical-devices-system-image: | |
status: | Confirmed → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
About number "5" it is a bug on SDK check #1542319.