OpenStack Compute (nova)

Not all .po files compiled

Bug #1536226 reported by Andreas Jaeger
28
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
High
Sven Anderson
Glance
In Progress
High
Sven Anderson
OpenStack Compute (nova)
Fix Released
High
Sven Anderson
OpenStack Heat
Fix Released
Undecided
Sven Anderson
OpenStack Identity (keystone)
Fix Released
High
Sven Anderson
OpenStack Identity (keystone) newton-2 "n2"
neutron
Fix Released
Medium
Ihar Hrachyshka
neutron pike-1 "p-1"
openstack i18n
Won't Fix
Undecided
Unassigned

Bug Description

python setup.py compile_catalog only compiles one <domain>.po file per language to a <domain>.mo file. By default <domain> is the project name, that is nova.po. This means all other nova-log-*.po files are never compiled. The only way to get setup.py compile the other files is calling it several times with different domains set, like for instance `python setup.py --domain nova-log-info` and so on. Since this is not usual, it can be assumed that the usual packages don't contain all the .mo files.

See original description
Sven Anderson (ansiwen)
description: updated
Sven Anderson (ansiwen)
summary: - Not all pot files compiled
+ Not all .po files compiled
Revision history for this message
Sven Anderson (ansiwen) wrote :

Possible solutions:
- merging the .po files again
- document how to compile the files manually
- find a way to make setup.py compile all files... (can we trigger arbitrary commands from setup.py?)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/270789

Changed in nova:
assignee: nobody → Sven Anderson (ansiwen)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (master)

Change abandoned by Sven Anderson (<email address hidden>) on branch: master
Review: https://review.openstack.org/270789
Reason: Implemented in pbr instead.

Revision history for this message
Alan Pevec (apevec) wrote :

> Reason: Implemented in pbr instead.

Should PBR be added here as "Also affects project" or is there separate LP# ? What is the PBR review?

Revision history for this message
Sven Anderson (ansiwen) wrote :

Fixed in babel. Waiting for babel release.

Revision history for this message
Sean Dague (sdague) wrote :

This is now fixed in Nova I believe with our tox workaround

Changed in nova:
importance: Undecided → High
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/311753

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/311753
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ece7b8f1e7b6f2256f88531824c5c270ce487b30
Submitter: Jenkins
Branch: master

commit ece7b8f1e7b6f2256f88531824c5c270ce487b30
Author: Sven Anderson <email address hidden>
Date: Fri May 20 15:34:00 2016 +0200

    Let setup.py compile_catalog process all language files

    Two years ago the translation files have been split into several
    files, separating the log messages of different log levels from each
    other, like X.pot, X-log-warning.pot, X-log-info.pot, and so on.
    However, the setup.py command `compile_catalogs`, that comes from the
    babel package and compiles the corresponding .po files into .mo
    files, only supported one file per python package. This means that
    during packaging `compile_catalogs` never compiled the X-log-*.po
    files, so the corresponding translations were always missing.

    Since babel 2.3 the domain can be set to a space separated list of
    domains. This change adds the the additional log level files to the
    domain list.

    The obsolete check that .po and .pot files are valid is removed from
    tox.ini.

    Change-Id: I0d9cb16ac50caae570c57a1db6bed656bf13c3dc
    Closes-Bug: #1536226

Nikhil Komawar (nikhil-komawar)
Changed in glance:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Sven Anderson (ansiwen)
Revision history for this message
Andreas Jaeger (jaegerandi) wrote :

keystone change: https://review.openstack.org/#/c/319260/

Sven Anderson (ansiwen)
Changed in cinder:
assignee: nobody → Sven Anderson (ansiwen)
Changed in keystone:
assignee: nobody → Sven Anderson (ansiwen)
Changed in heat:
assignee: nobody → Sven Anderson (ansiwen)
Changed in neutron:
assignee: nobody → Sven Anderson (ansiwen)
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/nova 14.0.0.0b1

This issue was fixed in the openstack/nova 14.0.0.0b1 development milestone.

Sheel Rana (ranasheel2000)
Changed in cinder:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/319260
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=16d0cdba47a0ad976f1500cd91c420860c3ad149
Submitter: Jenkins
Branch: master

commit 16d0cdba47a0ad976f1500cd91c420860c3ad149
Author: Sven Anderson <email address hidden>
Date: Fri May 20 15:54:27 2016 +0200

    Let setup.py compile_catalog process all language files

    Two years ago the translation files have been split into several
    files, separating the log messages of different log levels from each
    other, like X.pot, X-log-warning.pot, X-log-info.pot, and so on.
    However, the setup.py command `compile_catalogs`, that comes from the
    babel package and compiles the corresponding .po files into .mo
    files, only supported one file per python package. This means that
    during packaging `compile_catalogs` never compiled the X-log-*.po
    files, so the corresponding translations were always missing.

    Since babel 2.3 the domain can be set to a space separated list of
    domains. This change adds the the additional log level files to the
    domain list.

    The obsolete check that .po and .pot files are valid is removed from
    tox.ini.

    Change-Id: I1f0bfb181e2b84ac6dd0ce61881cd2cc4400bdcb
    Closes-Bug: #1536226

Changed in keystone:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/319279
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1d8a6a96329b87300dcf711912ab3b1c9f428cf3
Submitter: Jenkins
Branch: master

commit 1d8a6a96329b87300dcf711912ab3b1c9f428cf3
Author: Sven Anderson <email address hidden>
Date: Fri May 20 16:23:55 2016 +0200

    Let setup.py compile_catalog process all language files

    Two years ago the translation files have been split into several
    files, separating the log messages of different log levels from each
    other, like X.pot, X-log-warning.pot, X-log-info.pot, and so on.
    However, the setup.py command `compile_catalogs`, that comes from the
    babel package and compiles the corresponding .po files into .mo
    files, only supported one file per python package. This means that
    during packaging `compile_catalogs` never compiled the X-log-*.po
    files, so the corresponding translations were always missing.

    Since babel 2.3 the domain can be set to a space separated list of
    domains. This change adds the the additional log level files to the
    domain list.

    The obsolete check that .po and .pot files are valid is removed from
    tox.ini.

    Change-Id: I4d05c98b8ddd1a8416d7e0bc0298e86a0adc77d8
    Closes-Bug: #1536226

Changed in heat:
status: New → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/heat 7.0.0.0b2

This issue was fixed in the openstack/heat 7.0.0.0b2 development milestone.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/keystone 10.0.0.0b2

This issue was fixed in the openstack/keystone 10.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on cinder (master)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.openstack.org/319276
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

OpenStack Infra (hudson-openstack)
Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/319276
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0adde01a06d81ab39f536794e178d0434e9783a2
Submitter: Jenkins
Branch: master

commit 0adde01a06d81ab39f536794e178d0434e9783a2
Author: Sven Anderson <email address hidden>
Date: Fri May 20 16:20:48 2016 +0200

    Let setup.py compile_catalog process all language files

    Two years ago the translation files have been split into several
    files, separating the log messages of different log levels from each
    other, like X.pot, X-log-warning.pot, X-log-info.pot, and so on.
    However, the setup.py command `compile_catalogs`, that comes from the
    babel package and compiles the corresponding .po files into .mo
    files, only supported one file per python package. This means that
    during packaging `compile_catalogs` never compiled the X-log-*.po
    files, so the corresponding translations were always missing.

    Since babel 2.3 the domain can be set to a space separated list of
    domains. This change adds the the additional log level files to the
    domain list.

    The obsolete check that .po and .pot files are valid is removed from
    tox.ini.

    Change-Id: I149c2254cb04297e598cfd3ca73b24efd0c8ef18
    Closes-Bug: #1536226

Changed in cinder:
status: In Progress → Fix Released
Steve Martinelli (stevemar)
Changed in keystone:
milestone: none → newton-2
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cinder 9.0.0.0rc1

This issue was fixed in the openstack/cinder 9.0.0.0rc1 release candidate.

Ihar Hrachyshka (ihar-hrachyshka)
Changed in neutron:
importance: Undecided → Medium
milestone: none → ocata-rc1
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

neutron review:

https://review.openstack.org/#/c/319353/

Changed in neutron:
milestone: ocata-rc1 → pike-1
milestone: pike-1 → ocata-rc1
status: New → In Progress
Armando Migliaccio (armando-migliaccio)
Changed in neutron:
milestone: ocata-rc1 → ocata-rc2
Armando Migliaccio (armando-migliaccio)
Changed in neutron:
milestone: ocata-rc2 → pike-1
OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: Sven Anderson (ansiwen) → Ihar Hrachyshka (ihar-hrachyshka)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/319353
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cf42abc85e385eac12123ccac63a7dd3eb4f83ce
Submitter: Jenkins
Branch: master

commit cf42abc85e385eac12123ccac63a7dd3eb4f83ce
Author: Sven Anderson <email address hidden>
Date: Fri May 20 18:35:52 2016 +0200

    Let setup.py compile_catalog process all language files

    Two years ago the translation files have been split into several
    files, separating the log messages of different log levels from each
    other, like X.pot, X-log-warning.pot, X-log-info.pot, and so on.
    However, the setup.py command `compile_catalogs`, that comes from the
    babel package and compiles the corresponding .po files into .mo
    files, only supported one file per python package. This means that
    during packaging `compile_catalogs` never compiled the X-log-*.po
    files, so the corresponding translations were always missing.

    Since babel 2.3 the domain can be set to a space separated list of
    domains. This change adds the the additional log level files to the
    domain list.

    Change-Id: I436072d03f401240df6d7b8348616bc7c4731c4a
    Closes-Bug: #1536226

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.0.0b1

This issue was fixed in the openstack/neutron 11.0.0.0b1 development milestone.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

we decided to drop translation support for log strings, so we no longer need to move this forward.
As an umbrella bug in openstack-i18n, this bug should be marked as Won't Fix.

Changed in openstack-i18n:
status: New → Won't Fix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on glance (master)

Change abandoned by Sean McGinnis (<email address hidden>) on branch: master
Review: https://review.opendev.org/319269
Reason: This is very old and I don't believe it is needed. Feel free to restore and continue working on it if there is still a need for it and you wish to pursue it.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.