openstack-ansible

evaluation issue inside openstack_hosts/sysstat.default.j2 template

Bug #1530979 reported by Bjoern
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
openstack-ansible
Fix Released
Medium
Bjoern
openstack-ansible mitaka-2
Kilo
Won't Fix
Medium
Unassigned
Liberty
Fix Released
Medium
Hector Gonzalez
openstack-ansible 12.0.7
Trunk
Fix Released
Medium
Bjoern
openstack-ansible mitaka-2

Bug Description

By default openstack_host_systat_enabled is set to true and after jinja parses the template the value is set to True within
openstack_hosts/templates/sysstat.default.j2 :

# Ansible managed: /opt/openstack-ansible/playbooks/roles/openstack_hosts/templates/sysstat.default.j2 modified on 2015-10-22 17:36:44 by root on bjoern-aio2

....

# Should sadc collect system activity informations? Valid values
# are "true" and "false". Please do not put other values, they
# will be overwritten by debconf!
ENABLED="True"

This will cause the issue that sysstat never starts on new systems unless it has been altered to lower case "true"

Bjoern (bjoern-t)
Changed in openstack-ansible:
assignee: nobody → Bjoern Teipel (bjoern-teipel)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible-openstack_hosts (master)

Fix proposed to branch: master
Review: https://review.openstack.org/263427

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible-openstack_hosts (master)

Reviewed: https://review.openstack.org/263427
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible-openstack_hosts/commit/?id=ee8f6345176333d5fa159a8788cfcaf5ae44ea27
Submitter: Jenkins
Branch: master

commit ee8f6345176333d5fa159a8788cfcaf5ae44ea27
Author: Bjoern Teipel <email address hidden>
Date: Mon Jan 4 15:02:41 2016 -0600

    Store openstack_host_sysstat_enabled as lower case value for sysstat.default.j2

    Sysstat won't enable unless the ENABLED switch has been set to true.
    Passing openstack_host_sysstat_enabled as true inside jinja will end
    up as a "True" value inside the /etc/default/sysstat rather then the
    expected "true" value and sysstat won't start.
    The added jinja filter lower will make sure that the boolean is always
    stored in lower case.
    Additionally openstack_host_systat_enabled was renamed to
    openstack_host_sysstat_enabled to better reflect the dependency to sysstat

    Change-Id: I6361433f990f96ca37dac7055062c17c2940bf70
    Closes-Bug: #1530979

Changed in openstack-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (liberty)

Fix proposed to branch: liberty
Review: https://review.openstack.org/283337

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-ansible (liberty)

Reviewed: https://review.openstack.org/283337
Committed: https://git.openstack.org/cgit/openstack/openstack-ansible/commit/?id=6193998108a98bfb8e1655749b9aea142a5eb520
Submitter: Jenkins
Branch: liberty

commit 6193998108a98bfb8e1655749b9aea142a5eb520
Author: Hector I Gonzalez <email address hidden>
Date: Mon Feb 22 18:48:55 2016 -0600

    Store openstack_host_sysstat_enabled as lower case value for sysstat.default.j2

    Sysstat won't enable unless the ENABLED switch has been set to true.
    Passing openstack_host_sysstat_enabled as true inside jinja will end
    up as a "True" value inside the /etc/default/sysstat rather then the
    expected "true" value and sysstat won't start.

    The added jinja filter lower will make sure that the boolean is always
    stored in lower case.

    Additionally 'openstack_host_systat_enabled' was renamed to
    'openstack_host_sysstat_enabled' to better reflect the dependency to
    sysstat.

    This is a backport of https://review.openstack.org/263427

    Change-Id: I4c8ac77c29ae4f3a1f6331fdaaab5d45abadcf44
    Closes-Bug: #1530979

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-ansible (kilo)

Fix proposed to branch: kilo
Review: https://review.openstack.org/284937

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 12.0.8

This issue was fixed in the openstack/openstack-ansible 12.0.8 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 12.0.9

This issue was fixed in the openstack/openstack-ansible 12.0.9 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 12.0.11

This issue was fixed in the openstack/openstack-ansible 12.0.11 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on openstack-ansible (kilo)

Change abandoned by Jesse Pretorius (odyssey4me) (<email address hidden>) on branch: kilo
Review: https://review.openstack.org/284937
Reason: Abandoning due to inactivity.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.