watcher

Watcher API - main() function contains duplicate setup

Bug #1522781 reported by Vincent Françoise
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
watcher
Fix Released
Low
Darren Shaw
watcher mitaka-2 "m2"

Bug Description

The following line is executed twice:

logging.setup(CONF, 'watcher')

The first time is within the prepare_service() function and the second one is inside the main() function in watcher/cmd/api.py

Vincent Françoise (vincent-francoise)
Changed in watcher:
importance: Undecided → Low
Darren Shaw (dronshaw)
Changed in watcher:
assignee: nobody → Darren Shaw (ds354m)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to watcher (master)

Fix proposed to branch: master
Review: https://review.openstack.org/253764

Changed in watcher:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to watcher (master)

Reviewed: https://review.openstack.org/253764
Committed: https://git.openstack.org/cgit/openstack/watcher/commit/?id=4a88220ffe8d4110ff9320dd4b9be6b318747673
Submitter: Jenkins
Branch: master

commit 4a88220ffe8d4110ff9320dd4b9be6b318747673
Author: Darren Shaw <email address hidden>
Date: Fri Dec 4 20:34:34 2015 -0600

    Remove duplicate setup in Watcher API main()

    main() duplicates code for oslo_log setup, which is first
    called within prepare_services(). This patches removes
    the duplication call in main()

    Change-Id: I712d3733218c18b2eb02d4bf26e54b29ef72a988
    Closes-Bug: #1522781

Changed in watcher:
status: In Progress → Fix Committed
Antoine Cabot (antoinecabot)
Changed in watcher:
milestone: none → mitaka-2
Vincent Françoise (vincent-francoise)
Changed in watcher:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.