Ubuntu
webbrowser-app package

3 autopilot test failures on desktop in narrow mode

Bug #1522344 reported by Olivier Tilloy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Undecided
Bill Filler
Canonical System Image ww02-2016 "ota9"
webbrowser-app (Ubuntu)
Fix Released
High
Olivier Tilloy

Bug Description

I’m seeing 3 autopilot failures when running the entire test suite on desktop in narrow mode (need to modify the width of the window to e.g. 50GU in src/app/BrowserWindow.qml):

    webbrowser_app.tests.test_keyboard.TestKeyboard.test_switch_tabs_from_tabs_view
    webbrowser_app.tests.test_tabs.TestTabsManagement.test_undo_close_tab_incognito
    webbrowser_app.tests.test_tabs.TestTabsManagement.test_undo_close_tab

Those must have sneaked in quite recently, maybe with the tab animation improvements at revision 1280.

Related branches

lp://staging/~osomon/webbrowser-app/fix-ap-failures-desktop-narrow
PS Jenkins bot: Approve (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 160 lines (+51/-14)
4 files modified
src/app/webbrowser/Browser.qml (+4/-4)
src/app/webbrowser/tabs-model.cpp (+3/-1)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+8/-9)
tests/unittests/tabs-model/tst_TabsModelTests.cpp (+36/-0)
Revision history for this message
Olivier Tilloy (osomon) wrote :

In fact the first failure is a regression from revision 1280, while the last two failures have never passed on desktop in narrow mode (they were added at revision 1271).

Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → In Progress
importance: Undecided → High
no longer affects: canonical-devices-system-image
Olivier Tilloy (osomon)
Changed in canonical-devices-system-image:
status: New → In Progress
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
milestone: none → ww02-2016
assignee: nobody → Bill Filler (bfiller)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20151204-0ubuntu1

---------------
webbrowser-app (0.23+16.04.20151204-0ubuntu1) xenial; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Fix 3 autopilot test failures on desktop in narrow mode. (LP:
    #1522344)
  * Fix multiple keyboard focus/shortcut issues. (LP: #1522776,
    #1522783, #1522757, #1522767)
  * Replace custom models (HistoryDomainListChronologicalModel,
    HistoryLastVisitDateModel and TopSitesModel) with simple, pure QML
    SortFilterModel instances. Remove entirely HistoryTimeframeModel
    which was not needed any longer. (LP: #1480947)
  * Skip a test that requires HTTPS support in the test suite, which is
    lacking for now.
  * Update translation template.

 -- Olivier Tilloy <email address hidden> Fri, 04 Dec 2015 11:06:50 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.