NestedServer.display_configuration_reset_when_application_exits segfaults
Bug #1522105 reported by
Alberto Aguirre
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Medium
|
Alberto Aguirre | ||
0.18 |
Fix Released
|
Medium
|
Alberto Aguirre | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
NestedServer.
One can reproduce with
mir_acceptance_
Related branches
lp://staging/~albaguirre/mir/fix-1522105
Rejected
for merging
into
lp://staging/mir
- Alan Griffiths: Abstain
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 253 lines (+87/-24)3 files modifiedsrc/server/scene/surface_stack.cpp (+15/-9)
src/server/scene/surface_stack.h (+5/-4)
tests/unit-tests/scene/test_surface_stack.cpp (+67/-11)
lp://staging/~alan-griffiths/mir/fix-1522105
- Kevin DuBois (community): Approve
- Alberto Aguirre (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 348 lines (+96/-35)3 files modifiedsrc/server/scene/surface_stack.cpp (+27/-23)
src/server/scene/surface_stack.h (+2/-1)
tests/unit-tests/scene/test_surface_stack.cpp (+67/-11)
tags: | added: nested testsfail |
Changed in mir: | |
assignee: | nobody → Alberto Aguirre (albaguirre) |
Changed in mir: | |
milestone: | 0.19.0 → 0.18.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir: | |
status: | Fix Released → Fix Committed |
To post a comment you must log in.
It looks like the culprit is SurfaceStack: :add_observer, where the mutex guarding state changes to the vector of surfaces is dropped when calling the observer. This is problematic as another thread could call SurfaceStack: :remove_ surface.