Click hook should not allow more than a provider per plugin
Bug #1520605 reported by
Alberto Mardegan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
David Barth | ||
Online Accounts setup for Ubuntu Touch |
Fix Released
|
High
|
Alberto Mardegan | ||
webapps-sprint |
Fix Released
|
High
|
Alberto Mardegan |
Bug Description
The new click hook expects to find a "plugins" key in the JSON manifest file for Online Accounts, which would contain a list of plugins.
However, the click manifest already allows a click package to ship more applications and account plugins in a single .click file, so this functionality is not needed. On the contrary, it's undesirable because it adds one more token to the provider name ("<package>
Removing this extra token also has the advantage that we can keep exactly the same provider ID we had with the old hooks, therefore minimizing changes for applications.
Related branches
lp://staging/~mardy/ubuntu-system-settings-online-accounts/plugin-hook-1520605
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Online Accounts: Pending requested
-
Diff: 188 lines (+48/-70)2 files modifiedclick-hooks/accounts.cpp (+32/-48)
tests/click-hooks/tst_online_accounts_hooks2.cpp (+16/-22)
lp://staging/~mardy/click-reviewers-tools/oa-plugin-1520605
- Jamie Strandboge (community): Needs Information
-
Diff: 66 lines (+16/-16)2 files modifiedclickreviews/cr_online_accounts.py (+14/-11)
clickreviews/tests/test_cr_online_accounts.py (+2/-5)
Changed in ubuntu-system-settings-online-accounts: | |
assignee: | nobody → Alberto Mardegan (mardy) |
importance: | Undecided → High |
status: | New → In Progress |
Changed in webapps-sprint: | |
milestone: | none → sprint-17 |
assignee: | nobody → Alberto Mardegan (mardy) |
importance: | Undecided → High |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
status: | New → Fix Committed |
importance: | Undecided → High |
assignee: | nobody → David Barth (dbarth) |
milestone: | none → ww02-2016 |
Changed in ubuntu-system-settings-online-accounts: | |
status: | In Progress → Fix Committed |
Changed in webapps-sprint: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-system-settings-online-accounts: | |
status: | Fix Committed → Fix Released |
Changed in webapps-sprint: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.