Version Matching and comparison must be done consistently in manila tempest tests
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Shared File Systems Service (Manila) |
Fix Released
|
High
|
Valeriy Ponomaryov | ||
python-manilaclient |
Fix Released
|
High
|
Valeriy Ponomaryov |
Bug Description
Going forward, we'll be performing a ton of version checks within manila_
In the manila core code, we sanitize the comparisons:
https:/
Since we can't reference a class within manila itself, we should have a helper definition exclusively in manila_
And wherever necessary, we should:
0) Always accept micro version as a string
1) Split the micro version into major and minor portions.
3) Either use the ComparableMixin (make a copy from manila/utils: https:/
or,
3) Perform comparison on major version and then,
4) Perform comparison on minor version.
https:/
Changed in manila: | |
assignee: | nobody → Goutham Pacha Ravi (gouthamr) |
Changed in manila: | |
assignee: | Goutham Pacha Ravi (gouthamr) → Valeriy Ponomaryov (vponomaryov) |
status: | New → In Progress |
Changed in manila: | |
milestone: | none → mitaka-2 |
importance: | Undecided → High |
Changed in python-manilaclient: | |
milestone: | none → mitaka-2 |
assignee: | nobody → Valeriy Ponomaryov (vponomaryov) |
importance: | Undecided → High |
status: | New → In Progress |
tags: | added: tempest |
Fix proposed to branch: master /review. openstack. org/257480
Review: https:/