OpenStack Dashboard (Horizon)

The Networks tests file is very large/ bloated

Bug #1514048 reported by Rob Cresswell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Unassigned
OpenStack Dashboard (Horizon) mitaka-1 "m1"

Bug Description

The networks tests files in Horizon contain tests for Ports, Subnets and Agents, although there is barely any interdependency aside from a couple of shared imports or strings. These resources should have their own tests files to avoid further bloating the networks file (currently well over 2000 lines)

Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/242867

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/242867
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7f3267f502413bb44cb35c8e03a24557257a7212
Submitter: Jenkins
Branch: master

commit 7f3267f502413bb44cb35c8e03a24557257a7212
Author: Rob Cresswell <email address hidden>
Date: Tue Nov 3 14:46:22 2015 +0900

    Separate Ports tests from Networks tests

    This patch separates the Ports tests from the Networks tests files
    due to file bloat. Similar patches will also split Subnets and Agents
    tests to make them more manageable.

    I've chosen to keep these patches separate so as to make them more
    easily reviewable. There are separate patches to improve the navigation,
    tab the Networks details page, and add more content to Port edit/create.

    Partial-Bug: 1514048
    Change-Id: Ida677f503c22de6d1160f2c972af3f99c04ee389

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/244104

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/244159

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/244159
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c971cf106da7842c7137a18dd3ca263dd3199e50
Submitter: Jenkins
Branch: master

commit c971cf106da7842c7137a18dd3ca263dd3199e50
Author: Rob Cresswell <email address hidden>
Date: Wed Nov 11 15:24:39 2015 +0000

    Separate agents tests from networks tests file

    This patch separates the Agents tests from the Networks tests file due
    to file bloat. Previously, this file contained tests for Networks,
    Subnets, Ports and DHCP Agents.

    Also added missing copyright back to Ports tests

    Change-Id: I61075c4b1bddb774046eac6eb11509d2edca3fc2
    Closes-Bug: 1514048

Changed in horizon:
status: In Progress → Fix Committed
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
importance: Undecided → Wishlist
milestone: none → mitaka-1
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/horizon 9.0.0.0b1

This issue was fixed in the openstack/horizon 9.0.0.0b1 development milestone.

Doug Hellmann (doug-hellmann)
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/244104
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=52128cca5e240118eb57b51880b8ff2ddb410af3
Submitter: Jenkins
Branch: master

commit 52128cca5e240118eb57b51880b8ff2ddb410af3
Author: Rob Cresswell <email address hidden>
Date: Wed Nov 11 13:08:12 2015 +0000

    Separate subnets tests from networks tests file

    This patch separates the Subnets tests from the Networks tests file due
    to file bloat. Previously, this file contained tests for Networks,
    Subnets, Ports and DHCP Agents.

    Change-Id: Ia4018d29338d3e30f57ab86b9660b3e32c3bbe8f
    Partial-Bug: 1514048

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.