OpenStack Shared File Systems Service (Manila)

Fix usage of assertions

Bug #1512207 reported by yapeng Yang on 2015-11-02

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Aodh	Fix Released	Undecided	Unassigned	Aodh mitaka-3 "M3"
Barbican	Fix Released	Undecided	Unassigned
Cinder	Invalid	Undecided	Unassigned
Cue	Fix Released	Undecided	Unassigned
Glance	Won't Fix	Low	yapeng Yang
Group Based Policy	Invalid	Undecided	Unassigned
Murano	Fix Released	Low	Unassigned	Murano mitaka-2 "m2"
OpenStack Compute (nova)	Invalid	Undecided	Unassigned
OpenStack DBaaS (Trove)	Fix Released	Undecided	Unassigned
OpenStack Dashboard (Horizon)	Fix Released	Undecided	yapeng Yang
OpenStack Health	Invalid	Undecided	Unassigned
OpenStack Identity (keystone)	Fix Released	Low	Steve Martinelli	OpenStack Identity (keystone) mitaka-1 "m1"
OpenStack Object Storage (swift)	In Progress	Undecided	yapeng Yang
OpenStack SDK	Fix Released	Undecided	Unassigned
OpenStack Shared File Systems Service (Manila)	Fix Released	Undecided	yapeng Yang
Packstack	Fix Released	Undecided	Unassigned
Rally	Fix Released	Undecided	Yatin Kumbhare
Sahara	Fix Released	Low	Unassigned	Sahara mitaka-1 "m1"
Solum	Fix Released	Undecided	Unassigned
Stackalytics	Fix Released	Undecided	Yatin Kumbhare
Vitrage	Fix Released	Undecided	Unassigned
congress	Fix Released	Undecided	Unassigned
kuryr	Fix Released	Undecided	LiuNanke
neutron	Fix Released	Undecided	Yatin Kumbhare
os-brick	Fix Released	Undecided	Unassigned
os-net-config	Fix Released	Undecided	Unassigned
oslo.cache	Fix Released	Undecided	Unassigned
oslo.messaging	Fix Released	Undecided	Unassigned
python-ceilometerclient	Fix Released	Undecided	Unassigned
python-novaclient	Fix Released	Undecided	yapeng Yang
python-openstackclient	Fix Released	Undecided	Unassigned
requests-mock	Won't Fix	Undecided	Unassigned
shaker	Fix Released	Undecided	Unassigned
watcher	Fix Released	Undecided	Unassigned
zaqar	Fix Released	Undecided	Unassigned

Bug Description

Manila should use the specific assertion:

self.assertIsTrue/False(observed)

instead of the generic assertion:

self.assertEqual(True/False, observed)

yapeng Yang (yang-yapeng) on 2015-11-02

affects:

neutron → manila

OpenStack Infra (hudson-openstack) on 2015-11-02

Changed in manila:
assignee:	nobody → yapeng Yang (yang-yapeng)
status:	New → In Progress

Goutham Pacha Ravi (gouthamr) on 2015-11-02

summary:

- manila
+ Fix usage of assertions in Manila unit tests

Revision history for this message

Steve Martinelli (stevemar) wrote on 2015-11-02: Re: Fix usage of assertions in Manila unit tests

keystone patch here: https://review.openstack.org/#/c/240762/

Changed in keystone:
status:	New → In Progress
importance:	Undecided → Low
assignee:	nobody → yapeng Yang (yang-yapeng)

OpenStack Infra (hudson-openstack) on 2015-11-02

Changed in keystone:
assignee:	yapeng Yang (yang-yapeng) → Steve Martinelli (stevemar)

venkatamahesh (venkatamaheshkotha) on 2015-11-02

summary:	- Fix usage of assertions in Manila unit tests + Fix usage of assertions in keystone
summary:	- Fix usage of assertions in keystone + Fix usage of assertions

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-11-02: Fix merged to keystone (master)

Reviewed: https://review.openstack.org/240762
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=f44ecae73cbaefdd6a264d4e433bb4d08c51190a
Submitter: Jenkins
Branch: master

commit f44ecae73cbaefdd6a264d4e433bb4d08c51190a
Author: yangyapeng <yang.yapeng@99cloud.net>
Date: Wed Oct 28 13:18:44 2015 -0400

Use assertTrue/False instead of assertEqual(T/F)

    The usage of assertEqual(True/False, ***) should be changed
    to a meaningful format of assertTrue/False(***).
    This patch fixes the same in keystone.

Change-Id: I2b67c34796c54b0963fbc7020d4e78ed4f71c7f3
Closes-Bug: #1512207

Changed in keystone:
status:	In Progress → Fix Committed

Vitalii Gridnev (vgridnev) on 2015-11-02

Changed in sahara:
status:	New → In Progress
importance:	Undecided → Low

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-11-02: Fix merged to sahara (master)

Reviewed: https://review.openstack.org/240824
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=63a67d16a33026a0540b07a8750d4d584fdb2aa8
Submitter: Jenkins
Branch: master

commit 63a67d16a33026a0540b07a8750d4d584fdb2aa8
Author: yangyapeng <yang.yapeng@99cloud.net>
Date: Wed Oct 28 18:25:36 2015 -0400

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: I4e1918426e39a70c8b971d171d774ad5e241f2ae
Closes-Bug: #1512207

Changed in sahara:
status:	In Progress → Fix Committed

Vitalii Gridnev (vgridnev) on 2015-11-02

Changed in sahara:
milestone:	none → mitaka-1

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2015-11-03: Fix merged to manila (master)

Reviewed: https://review.openstack.org/240746
Committed: https://git.openstack.org/cgit/openstack/manila/commit/?id=fe1071267bbce793154425ee827e6f4dfe41ee80
Submitter: Jenkins
Branch: master

commit fe1071267bbce793154425ee827e6f4dfe41ee80
Author: yangyapeng <yang.yapeng@99cloud.net>
Date: Wed Oct 28 10:43:34 2015 -0400

Use assertTrue/False instead of assertEqual(T/F)

    The usage of assertEqual(True/False, ***) should be changed
    to a meaningful format of assertTrue/False(***).
    This patch fixes the same in Manila.

Change-Id: I0623c17a939e5175c15986dc7b6b64114c346c78
Closes-Bug: #1512207

Changed in manila:
status:	In Progress → Fix Committed

Steve Martinelli (stevemar) on 2015-12-01

Changed in keystone:
milestone:	none → mitaka-1

Revision history for this message

Thierry Carrez (ttx) wrote on 2015-12-03: Fix included in openstack/keystone 9.0.0.0b1

This issue was fixed in the openstack/keystone 9.0.0.0b1 development milestone.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2015-12-03: Fix included in openstack/sahara 4.0.0.0b1

This issue was fixed in the openstack/sahara 4.0.0.0b1 development milestone.

Changed in sahara:
status:	Fix Committed → Fix Released

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2015-12-03: Fix included in openstack/manila 2.0.0.0b1

This issue was fixed in the openstack/manila 2.0.0.0b1 development milestone.

Changed in manila:
status:	Fix Committed → Fix Released

Doug Hellmann (doug-hellmann) on 2015-12-03

Changed in keystone:
status:	Fix Committed → Fix Released

yapeng Yang (yang-yapeng) on 2016-01-06

Changed in swift:
assignee:	nobody → yapeng Yang (yang-yapeng)

OpenStack Infra (hudson-openstack) on 2016-01-06

Changed in swift:
status:	New → In Progress

yapeng Yang (yang-yapeng) on 2016-01-06

Changed in horizon:
assignee:	nobody → yapeng Yang (yang-yapeng)

OpenStack Infra (hudson-openstack) on 2016-01-06

Changed in horizon:
status:	New → In Progress

yapeng Yang (yang-yapeng) on 2016-01-06

Changed in glance:
assignee:	nobody → yapeng Yang (yang-yapeng)

OpenStack Infra (hudson-openstack) on 2016-01-06

Changed in glance:
status:	New → In Progress

yapeng Yang (yang-yapeng) on 2016-01-06

Changed in python-novaclient:
assignee:	nobody → yapeng Yang (yang-yapeng)

Niall Bunting (niall-bunting) on 2016-01-06

Changed in glance:
importance:	Undecided → Low

Yatin Kumbhare (yatinkumbhare-c) on 2016-01-06

Changed in rally:
assignee:	nobody → Yatin Kumbhare (yatinkumbhare-c)
Changed in stackalytics:
assignee:	nobody → Yatin Kumbhare (yatinkumbhare-c)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to stackalytics (master)

Fix proposed to branch: master
Review: https://review.openstack.org/264102

Changed in stackalytics:
status:	New → In Progress

Yatin Kumbhare (yatinkumbhare-c) on 2016-01-06

Changed in neutron:
assignee:	nobody → Yatin Kumbhare (yatinkumbhare-c)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/264109

Changed in neutron:
status:	New → In Progress

Yatin Kumbhare (yatinkumbhare-c) on 2016-01-06

Changed in cinder:
assignee:	nobody → Yatin Kumbhare (yatinkumbhare-c)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to cinder (master)

#10

Fix proposed to branch: master
Review: https://review.openstack.org/264116

Changed in cinder:
status:	New → In Progress

Yatin Kumbhare (yatinkumbhare-c) on 2016-01-06

Changed in ironic:
assignee:	nobody → Yatin Kumbhare (yatinkumbhare-c)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to ironic (master)

#11

Fix proposed to branch: master
Review: https://review.openstack.org/264156

Changed in ironic:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix merged to python-novaclient (master)

#12

Reviewed: https://review.openstack.org/263561
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=06be50b97a28f490951ca44f9880be161a54ecc1
Submitter: Jenkins
Branch: master

commit 06be50b97a28f490951ca44f9880be161a54ecc1
Author: yangyapeng <yang.yapeng@99cloud.net>
Date: Mon Jan 4 09:39:02 2016 -0500

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: I66110e5fc1afdf9dd6824b1f7bcb7b2c091a272d
Closes-Bug: #1512207

Changed in python-novaclient:
status:	New → Fix Released

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-06

Changed in aodh:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to aodh (master)

#13

Fix proposed to branch: master
Review: https://review.openstack.org/264211

Changed in aodh:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-06

Changed in barbican:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to barbican (master)

#14

Fix proposed to branch: master
Review: https://review.openstack.org/264215

Changed in barbican:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-06

Changed in blazar:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to blazar (master)

#15

Fix proposed to branch: master
Review: https://review.openstack.org/264219

Changed in blazar:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-06

Changed in magnum:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to magnum (master)

#16

Fix proposed to branch: master
Review: https://review.openstack.org/264230

Changed in magnum:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-06

Changed in tempest:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to tempest-lib (master)

#17

Fix proposed to branch: master
Review: https://review.openstack.org/264234

Changed in tempest:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to tempest (master)

#18

Fix proposed to branch: master
Review: https://review.openstack.org/264236

Changed in neutron:
assignee:	Yatin Kumbhare (yatinkumbhare-c) → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to neutron-lbaas (master)

#19

Fix proposed to branch: master
Review: https://review.openstack.org/264238

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-06

Changed in zaqar:
assignee:	nobody → Swapnil Kulkarni (coolsvap)
Changed in solum:
assignee:	nobody → Swapnil Kulkarni (coolsvap)
Changed in refstack:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to refstack (master)

#20

Fix proposed to branch: master
Review: https://review.openstack.org/264244

Changed in refstack:
status:	New → In Progress

Revision history for this message

Swapnil Kulkarni (coolsvap-deactivatedaccount) wrote on 2016-01-06:

#21

https://review.openstack.org/#/c/264243/

Changed in oslo.utils:
assignee:	nobody → Swapnil Kulkarni (coolsvap)
Changed in solum:
status:	New → In Progress
Changed in zaqar:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-06

Changed in vitrage:
assignee:	nobody → Swapnil Kulkarni (coolsvap)
Changed in trove:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

1 comments hidden

view all 117 comments

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to trove (master)

#23

Fix proposed to branch: master
Review: https://review.openstack.org/264253

Changed in trove:
status:	New → In Progress
Changed in vitrage:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix proposed to vitrage (master)

#24

Fix proposed to branch: master
Review: https://review.openstack.org/264254

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix merged to stackalytics (master)

#25

Reviewed: https://review.openstack.org/264102
Committed: https://git.openstack.org/cgit/openstack/stackalytics/commit/?id=5f96b1f7ac3dfcc754c9a719e2c31139770482a5
Submitter: Jenkins
Branch: master

commit 5f96b1f7ac3dfcc754c9a719e2c31139770482a5
Author: Yatin Kumbhare <email address hidden>
Date: Wed Jan 6 15:30:23 2016 +0530

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: I144e949275f196a5826e2963515fd38f4dbf9286
Closes-Bug: #1512207

Changed in stackalytics:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix merged to zaqar (master)

#26

Reviewed: https://review.openstack.org/264240
Committed: https://git.openstack.org/cgit/openstack/zaqar/commit/?id=d65a0170ca62e2a97ad790353dabfbc666e68120
Submitter: Jenkins
Branch: master

commit d65a0170ca62e2a97ad790353dabfbc666e68120
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Wed Jan 6 21:22:27 2016 +0530

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: Ic17abbaef08cca5dea0da31b641926e6f4f0edd0
Closes-Bug:#1512207

Changed in zaqar:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-06: Fix merged to trove (master)

#27

Reviewed: https://review.openstack.org/264253
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=dfcb84854956954dda2e7d05d607df180b3e28e0
Submitter: Jenkins
Branch: master

commit dfcb84854956954dda2e7d05d607df180b3e28e0
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Wed Jan 6 21:52:01 2016 +0530

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: I79115953536c40505c99dd6e0a87adc2272a9727
Closes-Bug:#1512207

Changed in trove:
status:	In Progress → Fix Released

Kan (kansks) on 2016-01-07

Changed in ironic-inspector:
assignee:	nobody → Kan (kansks)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Fix proposed to ironic-inspector (master)

#28

Fix proposed to branch: master
Review: https://review.openstack.org/264522

Revision history for this message

ZongKai LI (zongkai) wrote on 2016-01-07:

#29

The target has been done in neutron.

Changed in neutron:
assignee:	Swapnil Kulkarni (coolsvap) → nobody
status:	In Progress → Invalid

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Change abandoned on refstack (master)

#30

Change abandoned by Swapnil Kulkarni (coolsvap) (<email address hidden>) on branch: master
Review: https://review.openstack.org/264244

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Fix merged to ironic-inspector (master)

#31

Reviewed: https://review.openstack.org/264522
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=2612cab7b36dd38644a77f6ece5b59e8ae552cae
Submitter: Jenkins
Branch: master

commit 2612cab7b36dd38644a77f6ece5b59e8ae552cae
Author: Kan <email address hidden>
Date: Thu Jan 7 02:41:48 2016 +0000

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***)

Change-Id: I0b20247ff52df5df552adc3daaaa3a0107cfb7fd
Closes-Bug: #1512207

Changed in ironic-inspector:
status:	In Progress → Fix Released

Revision history for this message

Swapnil Kulkarni (coolsvap-deactivatedaccount) wrote on 2016-01-07:

#32

https://review.openstack.org/#/c/264249

Changed in oslo.utils:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in cue:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in congress:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Fix proposed to congress (master)

#33

Fix proposed to branch: master
Review: https://review.openstack.org/264598

Changed in congress:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in os-brick:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Fix proposed to os-brick (master)

#34

Fix proposed to branch: master
Review: https://review.openstack.org/264600

Changed in os-brick:
status:	New → In Progress

Revision history for this message

Swapnil Kulkarni (coolsvap-deactivatedaccount) wrote on 2016-01-07:

#35

https://review.openstack.org/264594

Changed in cue:
status:	New → In Progress
Changed in oslo.cache:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Fix proposed to oslo.cache (master)

#36

Fix proposed to branch: master
Review: https://review.openstack.org/264605

Changed in oslo.cache:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in os-net-config:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Fix proposed to os-net-config (master)

#37

Fix proposed to branch: master
Review: https://review.openstack.org/264607

Changed in os-net-config:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in openstack-health:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Fix proposed to openstack-health (master)

#38

Fix proposed to branch: master
Review: https://review.openstack.org/264613

Changed in openstack-health:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in oslo.messaging:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Fix proposed to oslo.messaging (master)

#39

Fix proposed to branch: master
Review: https://review.openstack.org/264615

Changed in oslo.messaging:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in packstack:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-07: Fix proposed to packstack (master)

#40

Fix proposed to branch: master
Review: https://review.openstack.org/264617

Changed in packstack:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in python-barbicanclient:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in python-barbicanclient:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in python-ceilometerclient:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in python-ceilometerclient:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in python-openstackclient:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in python-openstackclient:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in python-openstacksdk:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in python-openstacksdk:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in neutron:
assignee:	nobody → Yatin Kumbhare (yatinkumbhare-c)
status:	Invalid → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in watcher:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in watcher:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in tuskar:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in tuskar:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in group-based-policy:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in group-based-policy:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in watcher:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in ironic:
status:	In Progress → Fix Released

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in os-testr:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in os-testr:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in shaker:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in shaker:
status:	New → In Progress
Changed in python-openstackclient:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in vitrage:
status:	In Progress → Fix Released

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in requests-mock:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in requests-mock:
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in rally:
status:	New → In Progress

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-01-07

Changed in murano:
assignee:	nobody → Swapnil Kulkarni (coolsvap)

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in murano:
status:	New → In Progress

Niall Bunting (niall-bunting) on 2016-01-07

Changed in glance:
status:	In Progress → Won't Fix

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in horizon:
status:	In Progress → Fix Released

Bo Chi (bochi-michael) on 2016-01-07

Changed in nova:
assignee:	nobody → Bo Chi (bochi-michael)
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in oslo.messaging:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in aodh:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in python-ceilometerclient:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-07

Changed in python-openstacksdk:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-08

Changed in barbican:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-08

Changed in packstack:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-08

Changed in congress:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-08

Changed in oslo.cache:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-08

Changed in shaker:
status:	In Progress → Fix Released

OpenStack Infra (hudson-openstack) on 2016-01-08

Changed in os-brick:
status:	In Progress → Fix Released

LiuNanke (nanke-liu) on 2016-01-09

Changed in kuryr:
assignee:	nobody → LiuNanke (nanke-liu)
status:	New → In Progress

OpenStack Infra (hudson-openstack) on 2016-01-10

Changed in neutron:
status:	In Progress → Fix Released

Eric Harney (eharney) on 2016-01-12

Changed in cinder:
assignee:	Yatin Kumbhare (yatinkumbhare-c) → nobody
status:	In Progress → Invalid

37 comments hidden

view all 117 comments

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-13: Change abandoned on requests-mock (master)

#78

Change abandoned by Swapnil Kulkarni (coolsvap) (<email address hidden>) on branch: master
Review: https://review.openstack.org/264687

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-13: Change abandoned on cinder (master)

#79

Change abandoned by Yatin Kumbhare (<email address hidden>) on branch: master
Review: https://review.openstack.org/264116

Stan Lagun (slagun) on 2016-01-13

Changed in murano:
milestone:	none → mitaka-3
importance:	Undecided → Low
milestone:	mitaka-3 → mitaka-2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-13: Fix merged to murano (master)

#80

Reviewed: https://review.openstack.org/264695
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=e9388fffb7bf6592c35ab0f6f6e218375173d6aa
Submitter: Jenkins
Branch: master

commit e9388fffb7bf6592c35ab0f6f6e218375173d6aa
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Thu Jan 7 15:24:50 2016 +0530

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: Ia51e577fd89a208e9574fea987652522cadffdc4
Closes-Bug:#1512207

Changed in murano:
status:	In Progress → Fix Released

Revision history for this message

Davanum Srinivas (DIMS) (dims-v) wrote on 2016-01-14: Fix included in openstack/oslo.cache 1.2.0

#81

This issue was fixed in the openstack/oslo.cache 1.2.0 release.

Revision history for this message

Davanum Srinivas (DIMS) (dims-v) wrote on 2016-01-14: Fix included in openstack/oslo.utils 3.4.0

#82

This issue was fixed in the openstack/oslo.utils 3.4.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-14: Change abandoned on tempest-lib (master)

#83

Change abandoned by Swapnil Kulkarni (coolsvap) (<email address hidden>) on branch: master
Review: https://review.openstack.org/264234

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-14: Change abandoned on tempest (master)

#84

Change abandoned by Swapnil Kulkarni (coolsvap) (<email address hidden>) on branch: master
Review: https://review.openstack.org/264236

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-14: Change abandoned on openstack-health (master)

#85

Change abandoned by Swapnil Kulkarni (coolsvap) (<email address hidden>) on branch: master
Review: https://review.openstack.org/264613

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-14: Change abandoned on python-barbicanclient (master)

#86

Change abandoned by Swapnil Kulkarni (coolsvap) (<email address hidden>) on branch: master
Review: https://review.openstack.org/264618

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-14: Change abandoned on os-testr (master)

#87

Change abandoned by Swapnil Kulkarni (coolsvap) (<email address hidden>) on branch: master
Review: https://review.openstack.org/264672

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-14: Fix merged to cue (master)

#88

Reviewed: https://review.openstack.org/264594
Committed: https://git.openstack.org/cgit/openstack/cue/commit/?id=76e97efa295dad799e5e9a7038a5c2152b287255
Submitter: Jenkins
Branch: master

commit 76e97efa295dad799e5e9a7038a5c2152b287255
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Thu Jan 7 11:53:59 2016 +0530

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: Ibc6da6ddf0966da2441711a0460ca837209ae274
Closes-Bug:#1512207

Changed in cue:
status:	In Progress → Fix Released

Revision history for this message

Davanum Srinivas (DIMS) (dims-v) wrote on 2016-01-18: Fix included in openstack/os-brick 0.8.0

#89

This issue was fixed in the openstack/os-brick 0.8.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-18: Fix merged to kuryr (master)

#90

Reviewed: https://review.openstack.org/265579
Committed: https://git.openstack.org/cgit/openstack/kuryr/commit/?id=992630a4abf7ae10a281bf7a6f767488161e4b01
Submitter: Jenkins
Branch: master

commit 992630a4abf7ae10a281bf7a6f767488161e4b01
Author: LiuNanke <email address hidden>
Date: Sun Jan 10 02:00:57 2016 +0800

Use assertTrue/False instead of assertEqual(T/F)

    The usage of assertEqual(True/False, ***) should be changed
    to a meaningful format of assertTrue/False(***).
    This patch fixes the same in keystone.
    Closes-Bug: #1512207

Change-Id: I800fe2c849ff089882064656c21350354b729025

Changed in kuryr:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-18: Fix merged to solum (master)

#91

Reviewed: https://review.openstack.org/264243
Committed: https://git.openstack.org/cgit/openstack/solum/commit/?id=520a7b6af0978cf8d772d54c213b4095afc8cca6
Submitter: Jenkins
Branch: master

commit 520a7b6af0978cf8d772d54c213b4095afc8cca6
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Wed Jan 6 21:25:28 2016 +0530

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: I555f4c94d324a292c1b8bf562c8ae74b56795803
Closes-Bug:#1512207

Changed in solum:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-19: Fix merged to rally (master)

#92

Reviewed: https://review.openstack.org/264100
Committed: https://git.openstack.org/cgit/openstack/rally/commit/?id=09ee07d4d22e92aaf54b79cb8c5d221a7d9ae77c
Submitter: Jenkins
Branch: master

commit 09ee07d4d22e92aaf54b79cb8c5d221a7d9ae77c
Author: Yatin Kumbhare <email address hidden>
Date: Wed Jan 6 15:24:50 2016 +0530

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: Ic07f2cbbbcabff1a5b6940f56521fda582b128a5
Closes-Bug: #1512207

Changed in rally:
status:	In Progress → Fix Released

Revision history for this message

Thierry Carrez (ttx) wrote on 2016-01-19: Fix included in openstack/neutron-lbaas 8.0.0.0b2

#93

This issue was fixed in the openstack/neutron-lbaas 8.0.0.0b2 development milestone.

Revision history for this message

Thierry Carrez (ttx) wrote on 2016-01-21: Fix included in openstack/barbican 2.0.0.0b2

#94

This issue was fixed in the openstack/barbican 2.0.0.0b2 development milestone.

Revision history for this message

Thierry Carrez (ttx) wrote on 2016-01-21: Fix included in openstack/zaqar 2.0.0.0b2

#95

This issue was fixed in the openstack/zaqar 2.0.0.0b2 development milestone.

Revision history for this message

Thierry Carrez (ttx) wrote on 2016-01-21: Fix included in openstack/trove 5.0.0.0b2

#96

This issue was fixed in the openstack/trove 5.0.0.0b2 development milestone.

Revision history for this message

Thierry Carrez (ttx) wrote on 2016-01-21: Fix included in openstack/aodh 2.0.0.0b2

#97

This issue was fixed in the openstack/aodh 2.0.0.0b2 development milestone.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-01-21: Fix included in openstack/horizon 9.0.0.0b2

#98

This issue was fixed in the openstack/horizon 9.0.0.0b2 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-22: Change abandoned on tuskar (master)

#99

Change abandoned by Dougal Matthews (<email address hidden>) on branch: master
Review: https://review.openstack.org/264639
Reason: Abandoning changes against the retired repo.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-01-25: Fix included in openstack/ironic-inspector 3.0.0

#100

This issue was fixed in the openstack/ironic-inspector 3.0.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-27: Change abandoned on nova (master)

#101

Change abandoned by Bo Chi (<email address hidden>) on branch: master
Review: https://review.openstack.org/265711
Reason: don't think this is necessary

Bo Chi (bochi-michael) on 2016-01-27

Changed in nova:
assignee:	Bo Chi (bochi-michael) → nobody

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-27: Fix proposed to manila (master)

#102

Fix proposed to branch: master
Review: https://review.openstack.org/272939

Dougal Matthews (d0ugal) on 2016-01-27

no longer affects:

tuskar

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-01-28: Change abandoned on group-based-policy (master)

#103

Change abandoned by Sumit Naiksatam (<email address hidden>) on branch: master
Review: https://review.openstack.org/264642
Reason: The core team feels that the explicit comparison with True/False values is safer.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-02-02: Change abandoned on magnum (master)

#104

Change abandoned by Adrian Otto (<email address hidden>) on branch: master
Review: https://review.openstack.org/264230
Reason: I am marking this as abandoned due to inactivity. Please un-abandon this patch and address the gate check by submitting a revision.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-02-03: Change abandoned on manila (master)

#105

Change abandoned by daiki kato (<email address hidden>) on branch: master
Review: https://review.openstack.org/272939

Gábor Antal (gabor.antal) on 2016-02-03

Changed in nova:
assignee:	nobody → Gábor Antal (gabor.antal)
assignee:	Gábor Antal (gabor.antal) → nobody
status:	In Progress → Invalid

Revision history for this message

Davanum Srinivas (DIMS) (dims-v) wrote on 2016-02-03: Fix included in openstack/oslo.messaging 4.1.0

#106

This issue was fixed in the openstack/oslo.messaging 4.1.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-02-10: Fix included in openstack/python-openstackclient 2.1.0

#107

This issue was fixed in the openstack/python-openstackclient 2.1.0 release.

Davanum Srinivas (DIMS) (dims-v) on 2016-02-19

no longer affects:

oslo.utils

Catherine Diep (cdiep) on 2016-02-22

no longer affects:

refstack

Dmitry Tantsur (divius) on 2016-02-22

no longer affects:	ironic
no longer affects:	ironic-inspector

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-03-03: Fix included in openstack/solum 4.1.0

#108

This issue was fixed in the openstack/solum 4.1.0 release.

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-03-03: Fix included in openstack/ceilometermiddleware 0.4.0

#109

This issue was fixed in the openstack/ceilometermiddleware 0.4.0 release.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-03-08: Change abandoned on blazar (master)

#110

Change abandoned by Swapnil Kulkarni (coolsvap) (<email address hidden>) on branch: master
Review: https://review.openstack.org/264219

Revision history for this message

Doug Hellmann (doug-hellmann) wrote on 2016-03-11: Fix included in openstack/ironic 5.0.0

#111

This issue was fixed in the openstack/ironic 5.0.0 release.

Liusheng (liusheng) on 2016-03-21

Changed in aodh:
milestone:	none → mitaka-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-03-22: Fix merged to os-net-config (master)

#112

Reviewed: https://review.openstack.org/264607
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=e87fac0224b8f61ea8df4b219d1c4a5f76ee1915
Submitter: Jenkins
Branch: master

commit e87fac0224b8f61ea8df4b219d1c4a5f76ee1915
Author: Swapnil Kulkarni (coolsvap) <email address hidden>
Date: Thu Jan 7 12:13:40 2016 +0530

Use assertTrue/False instead of assertEqual(T/F)

The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: Ic15b6ebff7f050c1d516d9d680f362609803da4c
Closes-Bug:#1512207

Changed in os-net-config:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-05-07: Change abandoned on swift (master)

#113

Change abandoned by yapeng Yang (yang.yapeng@99cloud.net) on branch: master
Review: https://review.openstack.org/263560

Revision history for this message

Jamie Lennox (jamielennox) wrote on 2016-05-09:

#114

This weakens the assertion in our case. I don't want to test for the generic bool(value) case - i want to ensure that the functions are actually returning either True or False.

Changed in requests-mock:
status:	In Progress → Won't Fix

Revision history for this message

Masayuki Igawa (igawa) wrote on 2016-05-27:

#115

As Jordan pointed out, assertTrue(...) is not the same as assertEqual(True,...). So we should do this very carefully if we need to do. But I don't think it's worth while to take the risk.

Changed in openstack-health:
assignee:	Swapnil Kulkarni (coolsvap) → nobody
status:	In Progress → Invalid

Swapnil Kulkarni (coolsvap-deactivatedaccount) on 2016-07-11

Changed in group-based-policy:
status:	In Progress → Invalid
no longer affects:	os-testr
no longer affects:	python-barbicanclient
no longer affects:	tempest
no longer affects:	blazar
no longer affects:	magnum

Revision history for this message

John Griffith (john-griffith) wrote on 2016-07-28:

#116

First off as pointed out these aren't equivalent checks; second in what possible universe is this a "bug"?

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-11-10: Fix included in openstack/ceilometermiddleware 0.4.0

#117

This issue was fixed in the openstack/ceilometermiddleware 0.4.0 release.

Displaying first 40 and last 40 comments. View all 117 comments or add a comment.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.