Renaming not cancelled in list view with primary click on blank space
Bug #1508835 reported by
Jeremy Wootten
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Files |
Fix Released
|
Low
|
Jeremy Wootten | ||
Bug Description
In Icon view, renaming is cancelled by primary clicking on blank space but in views based on AbstractTreeView (the list and column views) this does not cancel renaming which seems inconsistent.
Related branches
lp://staging/~jeremywootten/pantheon-files/refactor-location-bar-part2
- Danielle Foré: Approve
- Adam Bieńkowski (community): Approve (functionality)
- Corentin Noël: Approve
- xapantu: Pending requested
-
Diff: 5596 lines (+2592/-2106)32 files modifiedfilechooser-module/CMakeLists.txt (+13/-8)
filechooser-module/FileChooserDialog.vala (+9/-9)
libcore/CMakeLists.txt (+0/-3)
libcore/pantheon-files-core-C.vapi (+5/-0)
libwidgets/CMakeLists.txt (+22/-26)
libwidgets/Chrome/BasicBreadcrumbsEntry.vala (+657/-0)
libwidgets/Chrome/BasicLocationBar.vala (+137/-0)
libwidgets/Chrome/BreadcrumbElement.vala (+253/-0)
libwidgets/Chrome/BreadcrumbIconList.vala (+152/-0)
libwidgets/Chrome/BreadcrumbsElements.vala (+0/-170)
libwidgets/Chrome/LocationBar.vala (+0/-881)
libwidgets/Chrome/TopMenu.vala (+35/-15)
libwidgets/Chrome/ViewWindowInterface.vala (+0/-35)
libwidgets/Chrome/Viewable.vala (+0/-32)
libwidgets/Dialogs/ChooseAppDialog.vala (+6/-2)
libwidgets/FileUtils.vala (+28/-1)
libwidgets/Interfaces/LocatableInterface.vala (+26/-0)
libwidgets/Interfaces/NavigatableInterface.vala (+43/-0)
libwidgets/Interfaces/SearchableInterface.vala (+33/-0)
libwidgets/MimeActions.vala (+22/-0)
libwidgets/Resources.vala (+11/-2)
libwidgets/View/BreadcrumbsEntry.vala (+548/-0)
libwidgets/View/LocationBar.vala (+189/-558)
libwidgets/View/SearchResults.vala (+250/-245)
plugins/contractor/CMakeLists.txt (+5/-0)
src/CMakeLists.txt (+1/-0)
src/View/AbstractDirectoryView.vala (+1/-1)
src/View/AbstractTreeView.vala (+10/-8)
src/View/DirectoryNotFound.vala (+3/-2)
src/View/IconView.vala (+8/-7)
src/View/ViewContainer.vala (+50/-29)
src/View/Window.vala (+75/-72)
| tags: | added: bitesize |
Revision history for this message
| Jeremy Wootten (jeremywootten) wrote | #1 |
| Changed in pantheon-files: | |
| assignee: | nobody → Jeremy Wootten (jeremywootten) |
| status: | New → In Progress |
| Changed in pantheon-files: | |
| status: | In Progress → Fix Committed |
| milestone: | none → loki-alpha1 |
| tags: | removed: bitesize |
| Changed in pantheon-files: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The branch lp:~jeremywootten/pantheon-files/refactor-location-bar-part2 seems to have fixed this as a side effect of fixing something else.