wily: collect_rabbitmq_stats.sh can't create lockfile
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
rabbitmq-server (Juju Charms Collection) |
Fix Released
|
Undecided
|
Ryan Beisner |
Bug Description
When nrpe is used with rabbitmq-server on Wily, the cron job which collects stats fails because the lockfile-create command isn't available (lockfile-progs package not installed in Wily deployments).
$ lockfile-create -r2 --lock-name /var/lock/
The program 'lockfile-create' is currently not installed. You can install it by typing:
sudo apt-get install lockfile-progs
...
This should fix it, validating...
=== modified file 'hooks/
--- hooks/rabbit_
+++ hooks/rabbit_
@@ -48,7 +48,7 @@
from collections import OrderedDict
-PACKAGES = ['rabbitmq-server', 'python-amqplib']
+PACKAGES = ['rabbitmq-server', 'python-amqplib', 'lockfile-progs']
RABBITMQ_CTL = '/usr/sbin/
COOKIE_PATH = '/var/lib/
=== modified file 'scripts/
--- scripts/
+++ scripts/
@@ -8,6 +8,7 @@
# Check for a lock file and if not, create one
lockfile-create -r2 --lock-name $LOCK > /dev/null 2>&1
if [ $? -ne 0 ]; then
+ echo "Failed to create lockfile: $LOCK."
exit 1
fi
trap "rm -f $LOCK > /dev/null 2>&1" exit
Related branches
- OpenStack Charmers: Pending requested
-
Diff: 2551 lines (+1504/-156)24 files modifiedMakefile (+1/-0)
hooks/charmhelpers/contrib/network/ip.py (+5/-3)
hooks/charmhelpers/contrib/openstack/amulet/deployment.py (+63/-9)
hooks/charmhelpers/contrib/openstack/amulet/utils.py (+359/-0)
hooks/charmhelpers/contrib/openstack/context.py (+100/-29)
hooks/charmhelpers/contrib/openstack/neutron.py (+17/-3)
hooks/charmhelpers/contrib/openstack/templates/ceph.conf (+6/-0)
hooks/charmhelpers/contrib/openstack/templating.py (+30/-2)
hooks/charmhelpers/contrib/openstack/utils.py (+233/-2)
hooks/charmhelpers/contrib/storage/linux/ceph.py (+226/-13)
hooks/charmhelpers/core/hookenv.py (+32/-0)
hooks/charmhelpers/core/host.py (+44/-17)
hooks/charmhelpers/core/hugepage.py (+10/-1)
hooks/charmhelpers/core/kernel.py (+68/-0)
hooks/charmhelpers/core/strutils.py (+30/-0)
hooks/rabbit_utils.py (+1/-1)
hooks/rabbitmq_server_relations.py (+4/-1)
scripts/collect_rabbitmq_stats.sh (+1/-0)
tests/README (+12/-0)
tests/basic_deployment.py (+68/-43)
tests/charmhelpers/contrib/amulet/deployment.py (+4/-2)
tests/charmhelpers/contrib/amulet/utils.py (+56/-16)
tests/charmhelpers/contrib/openstack/amulet/deployment.py (+109/-11)
tests/charmhelpers/contrib/openstack/amulet/utils.py (+25/-3)
description: | updated |
description: | updated |
Changed in rabbitmq-server (Juju Charms Collection): | |
assignee: | nobody → Ryan Beisner (1chb1n) |
status: | New → Confirmed |
status: | Confirmed → In Progress |
Changed in rabbitmq-server (Juju Charms Collection): | |
status: | In Progress → Fix Committed |
Changed in rabbitmq-server (Juju Charms Collection): | |
milestone: | none → 15.10 |
Changed in rabbitmq-server (Juju Charms Collection): | |
status: | Fix Committed → Fix Released |