Sahara

job binary can't be updated without url changing

Bug #1508507 reported by Andrey Pavlov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
High
Andrey Pavlov
Sahara mitaka-1 "m1"
Liberty
Fix Released
Medium
Andrey Pavlov
Mitaka
Fix Released
High
Andrey Pavlov
Sahara mitaka-1 "m1"

Bug Description

Job binary can't be updated if "url" is not provided in update parameters and fails with the following exception:

2015-10-21 17:43:48.947 24778 INFO sahara.utils.wsgi [-] 127.0.0.1 - - [21/Oct/2015 17:43:48] "POST /v1.1/09a442d0662e47d4bf009324facd3eb6/job-binaries HTTP/1.1" 202 473 0.030308
2015-10-21 17:44:02.087 24778 INFO sahara.utils.wsgi [-] 127.0.0.1 - - [21/Oct/2015 17:44:02] "GET /v1.1/09a442d0662e47d4bf009324facd3eb6/job-binaries HTTP/1.1" 200 1072 0.004877
2015-10-21 17:44:02.092 24778 ERROR sahara.utils.api [req-5aca35de-aed3-4eb2-9982-50ee8faac9d2 ] Request aborted with status code 500 and message 'Error occurred during validation'
2015-10-21 17:44:02.111 24778 ERROR sahara.utils.api [req-5aca35de-aed3-4eb2-9982-50ee8faac9d2 ] Traceback (most recent call last):
  File "/home/kshatrix/sahara/sahara/service/validation.py", line 37, in handler
    validator(**kwargs)
  File "/home/kshatrix/sahara/sahara/service/validations/edp/job_binary.py", line 26, in check_job_binary
    job_binary_location_type = data["url"]
KeyError: 'url'

Andrey Pavlov (apavlov-n)
Changed in sahara:
assignee: nobody → Andrey Pavlov (apavlov-n)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/238141

Changed in sahara:
status: New → In Progress
Vitalii Gridnev (vgridnev)
Changed in sahara:
importance: Undecided → High
milestone: none → mitaka-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (master)

Reviewed: https://review.openstack.org/238141
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=b0b5556a4609cc29dbd1d1a957229fd63481a29d
Submitter: Jenkins
Branch: master

commit b0b5556a4609cc29dbd1d1a957229fd63481a29d
Author: Andrey Pavlov <email address hidden>
Date: Wed Oct 21 18:29:02 2015 +0300

    Fixing problem with validation of job binaries update

    Job binary can't be updated without url changing

    Change-Id: Ibe41cde236837af34c422e2dea7979a260997759
    Closes-bug: #1508507

Changed in sahara:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to sahara (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/240523

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to sahara (stable/liberty)

Reviewed: https://review.openstack.org/240523
Committed: https://git.openstack.org/cgit/openstack/sahara/commit/?id=ece97e9cfce3719b8553e672cd2d06c52a0f844f
Submitter: Jenkins
Branch: stable/liberty

commit ece97e9cfce3719b8553e672cd2d06c52a0f844f
Author: Andrey Pavlov <email address hidden>
Date: Wed Oct 21 18:29:02 2015 +0300

    Fixing problem with validation of job binaries update

    Job binary can't be updated without url changing

    Change-Id: Ibe41cde236837af34c422e2dea7979a260997759
    Closes-bug: #1508507
    (cherry picked from commit b0b5556a4609cc29dbd1d1a957229fd63481a29d)

Doug Hellmann (doug-hellmann)
Changed in sahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.