OpenStack Dashboard (Horizon)

JS Unit Test Branch Coverage is Low

Bug #1506891 reported by Matt Borland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Coleman
OpenStack Dashboard (Horizon) mitaka-1 "m1"

Bug Description

The JS unit test branch coverage is within 0.25% of its threshold, meaning slight variations may cause patches to trigger coverage failures.

There are a few places where coverage is particularly bad that should be given more tests.

OpenStack Infra (hudson-openstack)
Changed in horizon:
assignee: nobody → Matt Borland (palecrow)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/237272

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/237788

Changed in horizon:
assignee: Matt Borland (palecrow) → Coleman (cbeasley)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/235984
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=08fb123f8b65dbe60cbcdda877dc9fa64c1725ad
Submitter: Jenkins
Branch: master

commit 08fb123f8b65dbe60cbcdda877dc9fa64c1725ad
Author: Matt Borland <email address hidden>
Date: Fri Oct 16 09:05:30 2015 -0600

    Improving JS unit test branch coverage

    This patch is testing untested branches.

    There is a bug in the Launch Instance model where it is supposed to
    remove null properties from the top level of the model. It is not doing
    that properly. So that bug is also fixed.

    This patch currently raises the branch coverage in openstack_dashboard
    from ~84% to ~89%.

    Closes-bug: 1506891
    Change-Id: I7434126246b15209b62daeff75744e0a3b435494

Changed in horizon:
status: In Progress → Fix Committed
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
importance: Undecided → High
milestone: none → mitaka-1
Doug Hellmann (doug-hellmann)
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/237272
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=56e4a599eb2b7b99d285fdac0c3390c99633be34
Submitter: Jenkins
Branch: master

commit 56e4a599eb2b7b99d285fdac0c3390c99633be34
Author: Rajat Vig <email address hidden>
Date: Mon Oct 19 15:41:58 2015 -0700

    Add test for the Heat Service validate method

    The suppressError condition for the validate method
    is not being tested.

    Change-Id: I53bd0c2f553752fe22f531100dbe83c3eeb1673c
    Parital-bug: #1506891

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/257440

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/257440
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=316aab1c3ba9ee8dfcf4ab014dadc7e41aea64dc
Submitter: Jenkins
Branch: master

commit 316aab1c3ba9ee8dfcf4ab014dadc7e41aea64dc
Author: Matt Borland <email address hidden>
Date: Mon Dec 14 08:17:12 2015 -0700

    Raise JS unit test coverage threshold

    As people have been raising the unit test coverage, we should make sure
    we're raising the thresholds as well. This keeps the new code from
    being lax in coverage.

    The metric used here was to set whole number percentage points that were
    more than one-half of a percentage point below the actual coverage.

    Change-Id: I348d4b8cafcf6c7d0dc8e770b66609984e89c20b
    Partial-Bug: 1506891

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/237788
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0bd3863faf441fb7f0f94bc9ac561270c39ab30f
Submitter: Jenkins
Branch: master

commit 0bd3863faf441fb7f0f94bc9ac561270c39ab30f
Author: cbeasley <email address hidden>
Date: Tue Oct 20 14:37:24 2015 -0700

    Add unit tests for load-edit directive

    Write unit tests for the directive to increase test coverage
    Split file read into a separate service for easier testing.

    Co-Authored-By: Matt Borland <email address hidden>
    Co-Authored-By: Shaoquan Chen <email address hidden>
    Co-Authored-By: Rajat Vig<email address hidden>

    Change-Id: Ie886c374b19d24351766bb48023ddfb7426b7a06
    Partial-Bug: #1506891

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.